[Piglit] [PATCH 3/4] shader_runner: add support for setting glActiveShaderProgram()

Kenneth Graunke kenneth at whitecape.org
Fri Dec 4 15:12:23 PST 2015


On Friday, December 04, 2015 09:11:05 PM Timothy Arceri wrote:
> This will allow us to set uniforms in SSO.
> 
> For example to make the fragment program active:
> active shader program GL_FRAGMENT_SHADER
> ---
>  tests/shaders/shader_runner.c | 13 +++++++++++++
>  1 file changed, 13 insertions(+)

This looks great, Timothy, thanks!

Patches 2-3 are:
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>

Patch 1 looks good as well.  I think it'd be simpler to have a single
flag in the [require] block rather than using [vertex sso], [fragment
sso], and so on...saves confusion as to what happens if you mix and
match [vertex sso] and [geometry shader].  With that change, I'd be
happy to give it an R-b as well.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20151204/48e7f45a/attachment.sig>


More information about the Piglit mailing list