[Piglit] [PATCH 2/2] framework: Don't try to parse GL/GLSL version from wflinfo.

[Dylan Baker]

On Mon, Dec 07, 2015 at 09:32:18AM -0500, Ilia Mirkin wrote:
> There's a bin/glinfo that it should be using. Relying on
> glxinfo/wflinfo/etc seems totally inappropriate.

bin/glinfo is woefully insufficient, it doesn't do gles, It doesn't do
core profile. It doesn't know about GLX, WGL, EGL, etc. and this feature
needs that. Writing a tool to do what there are already multiple tools
do feels very Not Invented Here to me.

> 
> On Mon, Dec 7, 2015 at 9:26 AM, Jose Fonseca <jfonseca at vmware.com> wrote:
> > It's making many assumptions about the wflinfo which are not true.
> >
> > So completely disable it as a workaround.
> >
> > Though I wonder if there's really any merit in adding a depending on
> > wflinfo.  IMO, if piglit cares for the advertised GL/GLSL versions, it
> > should have its own internally utility program to dump every thing needed.
> > Parsing output from external utilities is begging for trouble.
> > ---
> >  framework/test/opengl.py | 5 +++++
> >  1 file changed, 5 insertions(+)
> >
> > diff --git a/framework/test/opengl.py b/framework/test/opengl.py
> > index 29da2d1..0a7b2d7 100644
> > --- a/framework/test/opengl.py
> > +++ b/framework/test/opengl.py
> > @@ -80,6 +80,11 @@ class WflInfo(object):
> >          opts -- arguments to pass to wflinfo other than verbose and platform
> >
> >          """
> > +
> > +        # FIXME: The version parsing below is full of bugs.  Disable all
> > +        # wflinfo invocation until they are addressed
> > +        raise StopWflinfo('OSError')
> > +
> >          with open(os.devnull, 'w') as d:
> >              try:
> >                  raw = subprocess.check_output(
> > --
> > 2.5.0
> >
> > _______________________________________________
> > Piglit mailing list
> > Piglit at lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/piglit
> _______________________________________________
> Piglit mailing list
> Piglit at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/piglit
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20151207/350cfc6e/attachment-0001.sig>