[Piglit] [PATCH 2/2] framework: Don't try to parse GL/GLSL version from wflinfo.

[Dylan Baker]

On Mon, Dec 07, 2015 at 01:40:56PM -0500, Ilia Mirkin wrote:
> On Mon, Dec 7, 2015 at 1:38 PM, Dylan Baker <baker.dylan.c at gmail.com> wrote:
> > On Mon, Dec 07, 2015 at 09:32:18AM -0500, Ilia Mirkin wrote:
> >> There's a bin/glinfo that it should be using. Relying on
> >> glxinfo/wflinfo/etc seems totally inappropriate.
> >
> > bin/glinfo is woefully insufficient, it doesn't do gles, It doesn't do
> > core profile. It doesn't know about GLX, WGL, EGL, etc. and this feature
> > needs that. Writing a tool to do what there are already multiple tools
> > do feels very Not Invented Here to me.
> 
> It's conceivable that wflinfo is OK to use since it uses the same
> infra that piglit uses, but what bearing does glxinfo have on anything
> when I'm doing a run with gbm?
> 
>   -ilia

Nothing, and that's why the features uses waffle. And for us to
implement a tool that does what wflinfo does, would be to basically
reimplement wflinfo in piglit. That seems like a huge amount of
duplicated effort.

However, there are clearly some cases of drivers (or waffle + drivers)
being stupid that I didn't anticipate. I tested the two drivers I had
available to me (which both happen to be mesa based), so maybe Nvidia or
AMD have bugs in their proprietary drivers, or maybe the spec allows
version numbers that I didn't see when I glanced through looking to see
what was allowed.

Dylan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20151207/ba902695/attachment.sig>