[Piglit] [PATCH 3/3] framework: Temporarily disable parsing GL/GLSL version from wflinfo.

[Dylan Baker]

On Tue, Dec 08, 2015 at 01:23:30PM +0000, Jose Fonseca wrote:
> It's making many assumptions about the wflinfo output which are not
> always true.
> 
> So completely disable it as a temporary workaround.
> ---
>  framework/test/opengl.py | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/framework/test/opengl.py b/framework/test/opengl.py
> index 29da2d1..fa17873 100644
> --- a/framework/test/opengl.py
> +++ b/framework/test/opengl.py
> @@ -80,6 +80,12 @@ class WflInfo(object):
>          opts -- arguments to pass to wflinfo other than verbose and platform
>  
>          """
> +
> +        # FIXME: The version parsing below makes assumptions about wflinfo
> +        # output that are not always true.  Disable all wflinfo invocation
> +        # until they are addressed
> +        raise StopWflinfo('OSError')
> +
>          with open(os.devnull, 'w') as d:
>              try:
>                  raw = subprocess.check_output(
> -- 
> 2.5.0
> 

NAK. I sent a patch that should fix that issue, and this will introduce
an unacceptable slowdown in our setup.

If my patch is not sufficient for you please let me know why.

If you want an environment variable to mask this behavior I would be
more than happy to review or ack such a patch for you.

http://patchwork.freedesktop.org/patch/67308/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20151208/8edbed2b/attachment.sig>