[Piglit] [PATCH] igt: Restore handling of special igt error codes

Dylan Baker baker.dylan.c at gmail.com
Wed Dec 16 15:18:27 PST 2015


This will solve the issue, and shouldn't have any side effects. I think you
can actually just drop the super call (although, now that I look at it the
code in Test probably actually belongs in PiglitTest, but I digress).

On Wed, Dec 16, 2015 at 8:03 AM, Daniel Vetter <daniel.vetter at ffwll.ch>
wrote:

> In
>
> commit 5cbc1834fd47e7f475afc85e1638762e5b221a81
> Author: Dylan Baker <baker.dylan.c at gmail.com>
> Date:   Mon Dec 14 15:34:11 2015 -0800
>
>     framework/test/base.py: Handle fail cases for tests.
>
> the Test baseclass was made more robust in it's default behaviour, but
> that totally broke igt error code handling.
>
> CI is ... rather unhappy about it, so fix it asap.
>
> Cc: Dylan Baker <baker.dylan.c at gmail.com>
> Cc: Mark Janes <mark.a.janes at intel.com>
> Signed-off-by: Daniel Vetter <daniel.vetter at intel.com>
> ---
>  tests/igt.py | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/igt.py b/tests/igt.py
> index 4998ab203a23..074df08cc88c 100644
> --- a/tests/igt.py
> +++ b/tests/igt.py
> @@ -109,6 +109,8 @@ class IGTTest(Test):
>          self.timeout = 600
>
>      def interpret_result(self):
> +        super(IGTTest, self).interpret_result()
> +
>          if self.result.returncode == 0:
>              self.result.result = 'pass'
>          elif self.result.returncode == 77:
> @@ -118,8 +120,6 @@ class IGTTest(Test):
>          else:
>              self.result.result = 'fail'
>
> -        super(IGTTest, self).interpret_result()
> -
>
>  def list_tests(listname):
>      """Parse igt test list and return them as a list."""
> --
> 2.6.4
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20151216/06755ca0/attachment.html>


More information about the Piglit mailing list