[Piglit] [PATCH 5/4] framework/backends/junit.py; timeouts are errors

baker.dylan.c at gmail.com baker.dylan.c at gmail.com
Wed Dec 16 17:24:33 PST 2015


From: Dylan Baker <baker.dylan.c at gmail.com>

Previously a timeout would be marked as pass, but that makes no sense.
This marks it as an error.

v6: - add this patch

Signed-off-by: Dylan Baker <dylanx.c.baker at intel.com>
---

Apparently this isn't affecting anyone at the moment, but as soon as a
jenkins user turns on timeouts they're going to get some odd results.

 framework/backends/junit.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/framework/backends/junit.py b/framework/backends/junit.py
index 15c6c0b..abedff5 100644
--- a/framework/backends/junit.py
+++ b/framework/backends/junit.py
@@ -150,7 +150,7 @@ class JUnitBackend(FileBackend):
                 else:
                     res = etree.SubElement(element, 'failure')
 
-            elif data.result == 'crash':
+            elif data.result in ['crash', 'timeout']:
                 if expected_result == "error":
                     err.text += "\n\nWARN: passing test as an expected crash"
                     res = etree.SubElement(element, 'skipped',
-- 
2.6.4



More information about the Piglit mailing list