[Piglit] [PATCH] sso: Check piglit_link_check_status return value.

Timothy Arceri timothy.arceri at collabora.com
Tue Dec 22 15:10:03 PST 2015


On Tue, 2015-11-17 at 00:23 -0800, Vinson Lee wrote:
> Fixes Coverity "unchecked return value" defect.
> 
> Signed-off-by: Vinson Lee <vlee at freedesktop.org>
> ---
>  tests/spec/arb_separate_shader_objects/active-sampler-conflict.c | 2
> +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/spec/arb_separate_shader_objects/active-sampler
> -conflict.c b/tests/spec/arb_separate_shader_objects/active-sampler
> -conflict.c
> index 0a91f49..1c94b43 100644
> --- a/tests/spec/arb_separate_shader_objects/active-sampler
> -conflict.c
> +++ b/tests/spec/arb_separate_shader_objects/active-sampler
> -conflict.c
> @@ -124,7 +124,7 @@ setup_program(GLuint *prog, GLuint *pipe, GLuint
> *vao,
>  
>  	*prog = glCreateShaderProgramv(GL_FRAGMENT_SHADER, 1,
>  				      (const GLchar *const *)
> fs_code);
> -	piglit_link_check_status(*prog);
> +	pass = piglit_link_check_status(*prog) && pass;

Reviewed-by: Timothy Arceri <timothy.arceri at collabora.com>

>  
>  	glGenProgramPipelines(1, pipe);
>  	glUseProgramStages(*pipe,


More information about the Piglit mailing list