[Piglit] [PATCH] CL: Fix check of ULP when probing float/double results

Ilia Mirkin imirkin at alum.mit.edu
Tue Dec 29 12:28:26 PST 2015


On Tue, Dec 29, 2015 at 3:18 PM, Aaron Watry <awatry at gmail.com> wrote:
> Regardless of whether 0.0 is the absolutely correct answer for
> cos(1.57079632679), we can hopefully all agree that -4.0 is NOT a valid
> answer for cosine of anything

Right so that's clearly wrong :) I was largely warning you about some
of the issues we ran into trying to compute ULPs, and especially
combining them with each other. The GL_ARB_shader_precision text is
quite precise and similarly difficult to test -- e.g. fma() is allowed
to be fused or non-fused, at the implementation's option. But that
causes all sorts of results to be way different.

Perhaps you don't have these issues in the OpenCL specs.

  -ilia


More information about the Piglit mailing list