[Piglit] [PATCH] arb_shader_draw_parameters: test define

Ilia Mirkin imirkin at alum.mit.edu
Wed Dec 30 16:34:54 PST 2015


Hm, the spec wants GL 3.1, i.e. #version 140. I think it got left
enabled in mesa for compat so that it's available there, but the
piglit tests should go with what's in the spec. With that fixed,

Reviewed-by: Ilia Mirkin <imirkin at alum.mit.edu>

On Wed, Dec 30, 2015 at 7:17 PM, Timothy Arceri
<timothy.arceri at collabora.com> wrote:
> Cc: Ilia Mirkin <imirkin at alum.mit.edu>
> ---
>  .../arb_shader_draw_parameters/compiler/define.vert   | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
>  create mode 100644 tests/spec/arb_shader_draw_parameters/compiler/define.vert
>
> diff --git a/tests/spec/arb_shader_draw_parameters/compiler/define.vert b/tests/spec/arb_shader_draw_parameters/compiler/define.vert
> new file mode 100644
> index 0000000..0ac10ef
> --- /dev/null
> +++ b/tests/spec/arb_shader_draw_parameters/compiler/define.vert
> @@ -0,0 +1,19 @@
> +// [config]
> +// expect_result: pass
> +// glsl_version: 1.30
> +// require_extensions: GL_ARB_shader_draw_parameters
> +// [end config]
> +
> +#version 130
> +#extension GL_ARB_shader_draw_parameters: require
> +
> +#if !defined GL_ARB_shader_draw_parameters
> +#  error GL_ARB_shader_draw_parameters is not defined
> +#elif GL_ARB_shader_draw_parameters != 1
> +#  error GL_ARB_shader_draw_parameters is not equal to 1
> +#endif
> +
> +/* Some compilers generate spurious errors if a shader does not contain
> + * any code or declarations.
> + */
> +int foo(void) { return 1; }
> --
> 2.4.3
>


More information about the Piglit mailing list