[Piglit] [PATCH] arb_shader_image_load_store: fix MSVC build
jfonseca at vmware.com
Tue Feb 3 13:02:22 PST 2015
On 03/02/15 20:08, Francisco Jerez wrote:
> Francisco Jerez <currojerez at riseup.net> writes:
>> Francisco Jerez <currojerez at riseup.net> writes:
>>> Brian Paul <brianp at vmware.com> writes:
>>>> MSVC doesn't seem to like function calls inside struct initializers.
>>> That's awful. But fine:
>>> Reviewed-by: Francisco Jerez <currojerez at riseup.net>
>> Actually it's surprising that you got it to build with so few changes.
>> I'd expect you to find *many* more function calls inside struct
>> initializers. Does it actually work with this change or did you forget
>> to include some files?
> Brian, if that's the case don't bother to fix all the function calls in
> struct initalizers, just let me know, I'd like to try a less intrusive
If this was C++ we could use C++ constructors. In fact, the code could
be substantially simplified.
I think we should make more use of C++ in piglit. MSVC C++ support is
far more polished than it's C support. But above all, C++ features like
classes and templates could save a lot of hand typing.
More information about the Piglit