[Piglit] [PATCH] arb_shader_precision: set tolerance for div/assign-div

Matt Turner mattst88 at gmail.com
Tue Feb 3 13:58:32 PST 2015


On Mon, Feb 2, 2015 at 6:04 AM, Ilia Mirkin <imirkin at alum.mit.edu> wrote:
> This makes the relevant tests pass on nvc0.
>
> Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu>
> ---
>  generated_tests/gen_shader_precision_tests.py | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/generated_tests/gen_shader_precision_tests.py b/generated_tests/gen_shader_precision_tests.py
> index b4664ea..0d24a80 100644
> --- a/generated_tests/gen_shader_precision_tests.py
> +++ b/generated_tests/gen_shader_precision_tests.py
> @@ -58,7 +58,10 @@ tolerances = {'pow': 16.0,
>                'log': 3.0,
>                'log2': 3.0,
>                'sqrt': 3.0,
> -              'inversesqrt': 2.0}
> +              'inversesqrt': 2.0,
> +              'op-div': 2.5,
> +              'op-assign-div': 2.5,
> +              }

Let me make sure I understand -- we're not /changing/ the tolerances
in this patch, we're just adding some missing ones?

If so, what tolerances were the tests using for division?

Also if so,

Reviewed-by: Matt Turner <mattst88 at gmail.com>


More information about the Piglit mailing list