[Piglit] [PATCH] arb_shader_precision: set tolerance for div/assign-div

Chris Forbes chrisf at ijw.co.nz
Tue Feb 3 14:21:19 PST 2015


Matt, the default if not specified is zero.

2.5 ulps agrees with the spec, so:

Reviewed-by: Chris Forbes <chrisf at ijw.co.nz>

On Wed, Feb 4, 2015 at 10:58 AM, Matt Turner <mattst88 at gmail.com> wrote:
> On Mon, Feb 2, 2015 at 6:04 AM, Ilia Mirkin <imirkin at alum.mit.edu> wrote:
>> This makes the relevant tests pass on nvc0.
>>
>> Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu>
>> ---
>>  generated_tests/gen_shader_precision_tests.py | 5 ++++-
>>  1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/generated_tests/gen_shader_precision_tests.py b/generated_tests/gen_shader_precision_tests.py
>> index b4664ea..0d24a80 100644
>> --- a/generated_tests/gen_shader_precision_tests.py
>> +++ b/generated_tests/gen_shader_precision_tests.py
>> @@ -58,7 +58,10 @@ tolerances = {'pow': 16.0,
>>                'log': 3.0,
>>                'log2': 3.0,
>>                'sqrt': 3.0,
>> -              'inversesqrt': 2.0}
>> +              'inversesqrt': 2.0,
>> +              'op-div': 2.5,
>> +              'op-assign-div': 2.5,
>> +              }
>
> Let me make sure I understand -- we're not /changing/ the tolerances
> in this patch, we're just adding some missing ones?
>
> If so, what tolerances were the tests using for division?
>
> Also if so,
>
> Reviewed-by: Matt Turner <mattst88 at gmail.com>
> _______________________________________________
> Piglit mailing list
> Piglit at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/piglit


More information about the Piglit mailing list