[Piglit] [PATCH] arb_shader_image_load_store: fix MSVC build

Francisco Jerez currojerez at riseup.net
Wed Feb 4 03:10:48 PST 2015


Brian Paul <brianp at vmware.com> writes:

> On 02/03/2015 01:08 PM, Francisco Jerez wrote:
>> Francisco Jerez <currojerez at riseup.net> writes:
>>
>>> Francisco Jerez <currojerez at riseup.net> writes:
>>>
>>>> Brian Paul <brianp at vmware.com> writes:
>>>>
>>>>> MSVC doesn't seem to like function calls inside struct initializers.
>>>>
>>>> That's awful.  But fine:
>>>> Reviewed-by: Francisco Jerez <currojerez at riseup.net>
>>>>
>>> Actually it's surprising that you got it to build with so few changes.
>>> I'd expect you to find *many* more function calls inside struct
>>> initializers.  Does it actually work with this change or did you forget
>>> to include some files?
>>>
>>
>> Brian, if that's the case don't bother to fix all the function calls in
>> struct initalizers, just let me know, I'd like to try a less intrusive
>> solution.
>
> I'm just fixing the errors found via our automated build (which didn't 
> complete).  I don't have a MSVC piglit build on my local system ATM.
>
> -Brian

Hi Brian, if you still have trouble to get this to build with MSVC, can
you give the attached patch a try?

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-arb_shader_image_load_store-Remove-remaining-functio.patch
Type: text/x-diff
Size: 11739 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20150204/2a4e0f27/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 212 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20150204/2a4e0f27/attachment.sig>


More information about the Piglit mailing list