[Piglit] [Patch v2] cmake: Use waffle PackageConfig instead of pkg-find.

[Dylan Baker]

Well, isn't that what LD_LIBRARY_PATH is for? Linking or loading
libraries out of non standard locations I mean.

Looking through my usr/lib/cmake folder I'm seeing no one set full paths
for <project>_LIBRARIES.  I do see at least one project that defines
<project>_LIBRARIES as "-L${<project>_LIBRARY_DIRS} <project>", which
doesn't seem right to me.

I think I'll talk to the cmake guys and see what they think the right
solution is.

Consider this patch on hold until I get this sorted.

Dylan

On Tue, Feb 03, 2015 at 09:13:32PM +0000, Jose Fonseca wrote:
> Dylan,
> 
> 
> When the original commit went in, I also noticed one further issue (but 
> after the change was reverted I forgot to write it up):
> 
> 
> Waffle sets two variables Waffle_LIBRARY_DIRS and Waffle_LIBRARIES.
> 
> But with this change, piglit uses Waffle_LIBRARIES from Waffle, and 
> never uses Waffle_LIBRARY_DIRS, so if Waffle is installed into a non 
> standard place, piglit fails to build with "ld: cannot find -lwaffle-1"
> 
> (I hit this on my build slaves because I don't install waffle into /usr 
> or /usr/local.)
> 
> But worst thing is, I'm not sure this can be cleanly fixes from piglit 
> side.
> 
> We could add
> 
>    link_directories(${Waffle_LIBRARY_DIRS})
> 
> But per 
> http://www.cmake.org/cmake/help/v3.0/command/link_directories.html I 
> think the right fix would be to fix Waffle to export full paths in 
> Waffle_LIBRARIES, and kill Waffle_LIBRARY_DIRS.  I believe this is the 
> right way -- and cmake will emit the -L option automatically...
> 
> 
> Jose
> 

[snip]
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20150204/385f7096/attachment.sig>