[Piglit] [PATCH 2/3] Use alloca instead of variable length arrays

Ian Romanick idr at freedesktop.org
Mon Feb 9 11:17:59 PST 2015

On 02/06/2015 11:46 AM, Jose Fonseca wrote:
> I haven't tried this sort of code with MSVC 2013 U4, but at least in the
> past, MSVC 2013 was refusing certain kinds of variable length arrays.
> And Jan's patch is a stepping stone to -Wvla option  when compiling
> (option which apply to the whole tree, including parts that are not
> built with MSVC), in order to preemptively spot uses of VLA in places
> where MSVC would break.

In Mesa, we can change compiler options in subdirectories.  Is it
possible to do this with cmake?  Like, could we remove -Wvla in
directories that are only built on Linux?  It seems like that could give
us the best of both worlds...

> So let me do the following: I'll see if MSVC 2013 accepts or refuses the
> VLA code that caused problems the first time, and then we'll take it
> from there.
> Jose

More information about the Piglit mailing list