[Piglit] [PATCH 2/3] Use alloca instead of variable length arrays

Emil Velikov emil.l.velikov at gmail.com
Thu Feb 12 03:17:56 PST 2015

On 11 February 2015 at 16:12, Jan Vesely <jan.vesely at rutgers.edu> wrote:
> On Tue, 2015-02-10 at 10:28 -0800, Dylan Baker wrote:
>> I just want to be clear I was asking a question, I don't really care one
>> way or another, I would just rather not see code churn if it doesn't
>> actually buy us anything.
> Not sure what the question is here. The idea is to force msvc like
> limitations on other compilers by using -Werror= for unsupported
> features. It should result in fewer commits like [0].
> We can do it
> a) globally even for stuff that is never built using msvc
> b) per directory
> I think a) is better given that the required changes are minimal (only
> the two posted patches), and using alloca instead gives identical
> behavior. it makes codestyle consistent across files, and Jose's way of
> removing the flags using string function seems a bit hacky to me
Do you have a rough number how many tests warn about VLA currently ?
Must admit that I've very rarely look at the compilation output of
piglit. That combined the fact that new piglits get added
incrementally is a nice indication, imho, about one should handle

Or in other words - it there are only a few of tests that need fixing,
there should be no problem with adding this. Otherwise it's a
different story.


More information about the Piglit mailing list