[Piglit] [Mesa-dev] [PATCH] ARB_shader_atomic_counters: Add simple VS test with inc/dec/read

Ilia Mirkin imirkin at alum.mit.edu
Tue Feb 17 16:35:32 PST 2015


On Tue, Feb 17, 2015 at 7:12 PM, Jordan Justen
<jordan.l.justen at intel.com> wrote:
> +++ b/tests/spec/arb_shader_atomic_counters/execution/vs-simple-inc-dec-read.shader_test
> @@ -0,0 +1,70 @@
> +# Simple test of atomicCounterIncrement, atomicCounterDecrement and
> +# atomicCounter being used in the VS.
> +
> +[require]
> +GL CORE >= 3.1
> +GLSL >= 1.40

Why require core? Mesa exposes this in compat contexts too... (Also
you could just require GLSL >= 1.40 afaik...)

> +probe all rgba 0.0 1.0 0.0 1.0
> \ No newline at end of file

Please fix :)

May be good to also make a fs version of this. Lastly, an
implementation is only required to support this in fs... for the rest,
MAX_*_ATOMIC_COUNTERS may be 0. I guess there's no good way to
represent that in piglit... thoughts?

  -ilia


More information about the Piglit mailing list