[Piglit] [PATCH 3/3] cmake, gles: Remove target from the lib list

Jan Vesely jan.vesely at rutgers.edu
Fri Feb 20 07:19:51 PST 2015


On Fri, 2015-02-20 at 12:03 +0000, Jose Fonseca wrote:
> On 12/12/14 19:33, Jan Vesely wrote:
> > Fixes Target links to itself cmake warnings
> >
> > Signed-off-by: Jan Vesely <jan.vesely at rutgers.edu>
> > ---
> >
> > compile tested. no missing symbols or libraries reported for libpiglitutils_glesX.so
> >
> >   tests/util/CMakeLists.gles1.txt | 1 -
> >   tests/util/CMakeLists.gles2.txt | 1 -
> >   tests/util/CMakeLists.gles3.txt | 1 -
> >   3 files changed, 3 deletions(-)
> >
> > diff --git a/tests/util/CMakeLists.gles1.txt b/tests/util/CMakeLists.gles1.txt
> > index 4342cf2..cd9e90d 100644
> > --- a/tests/util/CMakeLists.gles1.txt
> > +++ b/tests/util/CMakeLists.gles1.txt
> > @@ -4,7 +4,6 @@ include_directories(
> >
> >   link_libraries(
> >   	${UTIL_GL_LIBS}
> > -	piglitutil_${piglit_target_api}
> >   	)
> >
> >   piglit_add_library(piglitutil_${piglit_target_api}
> > diff --git a/tests/util/CMakeLists.gles2.txt b/tests/util/CMakeLists.gles2.txt
> > index 4342cf2..cd9e90d 100644
> > --- a/tests/util/CMakeLists.gles2.txt
> > +++ b/tests/util/CMakeLists.gles2.txt
> > @@ -4,7 +4,6 @@ include_directories(
> >
> >   link_libraries(
> >   	${UTIL_GL_LIBS}
> > -	piglitutil_${piglit_target_api}
> >   	)
> >
> >   piglit_add_library(piglitutil_${piglit_target_api}
> > diff --git a/tests/util/CMakeLists.gles3.txt b/tests/util/CMakeLists.gles3.txt
> > index fec284a..a23c0c7 100644
> > --- a/tests/util/CMakeLists.gles3.txt
> > +++ b/tests/util/CMakeLists.gles3.txt
> > @@ -4,7 +4,6 @@ include_directories(
> >
> >   link_libraries(
> >   	${UTIL_GL_LIBS}
> > -	piglitutil_${piglit_target_api}
> >   	)
> >
> >   piglit_add_library(piglitutil_${piglit_target_api}
> >
> 
> Reviewed-by: Jose Fonseca <jfonseca at vmware.com>

thanks, but this patch went in some time ago.
I pushed the other two and posted the correct warning->error one.
sorry for the hassle, I should have grouped them better.

jan


-- 
Jan Vesely <jan.vesely at rutgers.edu>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20150220/26b46b7d/attachment-0001.sig>


More information about the Piglit mailing list