[Piglit] [PATCH] clearbuffer-invalid-drawbuffer: Fix test cases calling glClearBufferiv with depth buffers
Eduardo Lima Mitev
elima at igalia.com
Tue Feb 24 01:46:50 PST 2015
While testing this patch for a dEQP failing test on piglit:
I found a regression in test:
bin/clearbuffer-invalid-drawbuffer -auto -fbo
The test fails because it is not considering that glClearBufferiv should return an INVALID_ENUM error when called with a depth buffer, per following wording:
Page 262 of the PDF, section '4.2.3 Clearing the Buffers' of the
OpenGL 3.0 spec states:
"Only ClearBufferfv should be used to clear depth buffers."
And in the Errors definition of the same section (page 263 of the PDF):
"ClearBuffer generates an INVALID ENUM error if buffer does not
identify a valid buffer in or attachment of the currently bound
draw framebuffer, or if buffer is not one of the buffer names
specified as valid for that form of ClearBuffer command."
The nested patch fixes the piglit test and avoids the regression that will pop up when merging the above Mesa patch, which has already been reviewed and is ready to be pushed upstream.
The problem is that with this piglit patch, both proprietary AMD and NVidia fail the above test when it was passing before. So I have doubts about what to do.
Should I proceed and merge the Mesa patch?
Eduardo Lima Mitev (1):
clearbuffer-invalid-drawbuffer: Fix test cases calling glClearBufferiv
with depth buffers
.../gl-3.0/api/clearbuffer-invalid-drawbuffer.c | 36 ++++++++++++++--------
1 file changed, 24 insertions(+), 12 deletions(-)
More information about the Piglit