[Piglit] [PATCH 0/9] Direct State Access tests series

[Martin Peres]

On 16/02/15 15:12, Martin Peres wrote:
> Here are the tests I have been working on while implementing the following
> parts of the DSA extension:
> - Transform Feedback object
> - Renderbuffer object
> - Sampler object
> - Program Pipeline object
> - Query object
>
> This series adds 115 tests and requires patches I am about to send to the
> mesa-dev ML, the MESA_EXTENSION_OVERRIDE=GL_ARB_direct_state_access env
> variable and i915.enable_ppgtt=2 in order to all be run successfully on
> Haswell (only platform tested).
>
> Please test and review.

I ran those tests on NVIDIA and only three fail:
- create-queries "invalid target" : nvidia does not check the target as 
it should
- namedrenderbuffer "invalid format" : nvidia does not check the 
required format
(it accepts GL_TRUE instead of a valid format such as GL_RGBA)
- transformfeedback-bufferrange "bind a non-existing output BO" : 
Apparently,
binding an invalid BO id is legal with nvidia :o At least, it produces 
no error

Could I get more reviews please? I would like to push those on Friday!

Martin