[Piglit] [PATCH] cl: add atanpi tests

[Zhu, BingbingX]

OK! Got it. Thanks for the information. Another version with subject of "[PATCH v2] cl: add atanpi tests" is sent out .

Thanks
Zhu Bingbing

-----Original Message-----
From: Jan Vesely [mailto:jv356 at scarletmail.rutgers.edu] On Behalf Of Jan Vesely
Sent: Wednesday, January 07, 2015 8:25 PM
To: Zhu, BingbingX
Cc: piglit at lists.freedesktop.org
Subject: Re: [Piglit] [PATCH] cl: add atanpi tests

On Mon, 2015-01-05 at 15:43 +0800, Zhu Bingbing wrote:
> From: "Zhu, Bingbing" <bingbingx.zhu at intel.com>
> 
> This case will test common result and boundary result.
> 
> Signed-off-by: Zhu Bingbing <bingbingx.zhu at intel.com>

I think it would be nice to have a test case with result needing more then 2 decimal places, (something like atanpi(0.12345) would do).
with that change,
Reviewed-by: Jan Vesely <jan.vesely at rutgers.edu>

> ---
>  generated_tests/generate-cl-math-builtins.py | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/generated_tests/generate-cl-math-builtins.py 
> b/generated_tests/generate-cl-math-builtins.py
> index ce16a6b..764b245 100644
> --- a/generated_tests/generate-cl-math-builtins.py
> +++ b/generated_tests/generate-cl-math-builtins.py
> @@ -37,6 +37,7 @@ CLC_VERSION_MIN = {
>      'atan' : 10,
>      'atan2' : 10,
>      'atanh' : 10,
> +    'atanpi': 10,
>      'cbrt' : 10,
>      'ceil' : 10,
>      'copysign' : 10,
> @@ -138,6 +139,15 @@ tests = {
>          ],
>          'tolerance' : 4
>       },
> +    'atanpi' : {
> +    'arg_types' : [F, F],
> +    'function_type': 'ttt',
> +    'values' : [
> +        [0.0, -0.0, atan(1.0)/pi, atan(-1.0)/pi, float("nan"), 0.5,          -0.5          ],
> +        [0.0, -0.0, 1.0,          -1.0,          float("nan"), float("inf"), float("-inf") ]
> +    ],
> +    'tolerance' : 5
> + },
>      'cbrt' : {
>          'arg_types': [F, F],
>          'function_type': 'ttt',


--
Jan Vesely <jan.vesely at rutgers.edu>