[Piglit] [PATCH] framebuffer-srgb: Remove dead assignment.

Brian Paul brianp at vmware.com
Thu Jan 8 15:03:52 PST 2015


On 01/08/2015 03:45 PM, Vinson Lee wrote:
> Fix Clang Static Analyzer dead assignment bug.
>
> Signed-off-by: Vinson Lee <vlee at freedesktop.org>
> ---
>   tests/general/framebuffer-srgb.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/general/framebuffer-srgb.c b/tests/general/framebuffer-srgb.c
> index 9f88df7..880adaf 100644
> --- a/tests/general/framebuffer-srgb.c
> +++ b/tests/general/framebuffer-srgb.c
> @@ -99,7 +99,7 @@ framebuffer_srgb_api_ext(void)
>   		pass = GL_FALSE;
>   	}
>
> -	is_enabled = glIsEnabled(GL_FRAMEBUFFER_SRGB_EXT);
> +	glIsEnabled(GL_FRAMEBUFFER_SRGB_EXT);

Let's make that

   (void) glIsEnabled(GL_FRAMEBUFFER_SRGB_EXT); /* ignore return value */

just to be clear.

With that, Reviewed-by: Brian Paul <brianp at vmware.com>


>   	ret = glGetError();
>   	if (ret != 0) {
>   		printf("unexpected error getting IsEnabled %d\n", ret);
>



More information about the Piglit mailing list