[Piglit] [PATCH piglit v2] texsubimage: Test GL_ARB_texture_cube_map_array

[Anuj Phogat]

On Fri, Jan 9, 2015 at 10:40 AM, Neil Roberts <neil at linux.intel.com> wrote:
>
> Anuj Phogat <anuj.phogat at gmail.com> writes:
>
> > Looking at the output image I assumed 6 rectangles drawn in a row show
> > 6 faces of the cubemap and 8 rows represent 8 layers. But draw coordinates
> > don't follow this pattern. It's not incorrect but confusing. I think what you
> > need here is:
> > piglit_draw_rect_tex3d(i % 6 * w, i / 6 * h, /* x/y */
>
> This is a bit awkward to change. I originally made it so that it would
> draw the 6 faces vertically like that because the function is also used
> to draw the 3D texture slices and I didn't want to mess with the
> appearance of that. If I make the change as you suggest then the 3D case
> will render six layers in one row with two layers in the second row
> which I think is weirder than having the cube faces not take up a single
> row. I would also have to increase the window size to 768 because the
> width of the 3D slices are 128. I was hoping to make the minimal changes
> and didn't think that lining up the cube faces would matter all that
> much.
>
> Regards,
> - Neil

Makes sense. Patch is:
Reviewed-by: Anuj Phogat <anuj.phogat at gmail.com>