[Piglit] [PATCH] piglit-print-commands.py: PEP8 fixes.

Brian Paul brianp at vmware.com
Sat Jan 10 06:43:57 PST 2015


On 01/09/2015 08:03 PM, Vinson Lee wrote:
> piglit-print-commands.py:41:32: E251 unexpected spaces around keyword / parameter equals
> piglit-print-commands.py:41:34: E251 unexpected spaces around keyword / parameter equals
> piglit-print-commands.py:42:31: E221 multiple spaces before operator
> piglit-print-commands.py:42:31: E251 unexpected spaces around keyword / parameter equals
> piglit-print-commands.py:42:34: E251 unexpected spaces around keyword / parameter equals
> piglit-print-commands.py:43:32: E251 unexpected spaces around keyword / parameter equals
> piglit-print-commands.py:43:34: E251 unexpected spaces around keyword / parameter equals
> piglit-print-commands.py:44:29: E221 multiple spaces before operator
> piglit-print-commands.py:44:29: E251 unexpected spaces around keyword / parameter equals
> piglit-print-commands.py:44:34: E251 unexpected spaces around keyword / parameter equals
> piglit-print-commands.py:44:80: E501 line too long (89 > 79 characters)
> piglit-print-commands.py:57:24: E128 continuation line under-indented for visual indent
>
> Signed-off-by: Vinson Lee <vlee at freedesktop.org>
> ---
>   piglit-print-commands.py | 11 ++++++-----
>   1 file changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/piglit-print-commands.py b/piglit-print-commands.py
> index af24902..be7e0ec 100755
> --- a/piglit-print-commands.py
> +++ b/piglit-print-commands.py
> @@ -38,10 +38,11 @@ def main():
>       core.get_config()
>       parser = argparse.ArgumentParser(sys.argv)
>       parser.add_argument("-t", "--include-tests",
> -                        default = [],
> -                        action  = "append",
> -                        metavar = "<regex>",
> -                        help    = "Run only matching tests (can be used more than once)")
> +                        default=[],
> +                        action="append",
> +                        metavar="<regex>",
> +                        help="Run only matching tests (can be used more than "
> +                             "once)")
>       parser.add_argument("-x", "--exclude-tests",
>                           default=[],
>                           action="append",
> @@ -54,7 +55,7 @@ def main():
>       args = parser.parse_args()
>
>       opts = core.Options(exclude_filter=args.exclude_tests,
> -                       include_filter=args.include_tests)
> +                        include_filter=args.include_tests)
>
>       # Change to the piglit's path
>       piglit_dir = path.dirname(path.realpath(sys.argv[0]))
>

For this, and "glx-query-drawable: Initialize variable" and 
"ext_framebuffer_multisample_blit_scaled: Use const reference",
Reviewed-by: Brian Paul <brianp at vmware.com>



More information about the Piglit mailing list