[Piglit] [PATCH] texture-packed-formats: Don't try bother with ABGR_EXT formats

[Samuel Iglesias Gonsálvez]

On Monday, January 12, 2015 01:14:23 PM Jason Ekstrand wrote:
> Since GL_ABGR_EXT was extension number 1 to the GL spec, it didn't take
> packed formats into account.  As far as I can tell from the way the packed
> formats extensions are written, packed formats with GL_ABGR_EXT isn't
> allowed by the spec.  NVIDIA allows it but AMD doesn't and our driver
> hasn't allowed ith with UNSIGNED_INT_5_5_5_1 as of c471b09bf4.  Let's stop
> testing invalid things.

Reviewed-by: Samuel Iglesias Gonsalvez <siglesias at igalia.com>

I sent yesterday morning a similar patch [0] that also stop testing those 
GL_ABGR_EXT format and type combinations in texture-packed-formats.c  and 
tests/glean/tpixelformats.cpp.

As your patch is more complete than mine for texture-packed-formats.c , I am 
going to modify mine and resend it once you have pushed this patch to master.

Sam

[0]  http://lists.freedesktop.org/archives/piglit/2015-January/014052.html

> ---
>  tests/texturing/texture-packed-formats.c | 13 -------------
>  1 file changed, 13 deletions(-)
> 
> diff --git a/tests/texturing/texture-packed-formats.c
> b/tests/texturing/texture-packed-formats.c index 1c92b1c..87da808 100644
> --- a/tests/texturing/texture-packed-formats.c
> +++ b/tests/texturing/texture-packed-formats.c
> @@ -89,19 +89,6 @@ static const struct pixel_format Formats[] = {
>  	{ "GL_BGRA/GL_UNSIGNED_SHORT_1_5_5_5_REV",
>  	  GL_BGRA, GL_UNSIGNED_SHORT_1_5_5_5_REV, 2, 0xfc00, 0x83e0 },
> 
> -	{ "GL_ABGR_EXT/GL_UNSIGNED_INT_8_8_8_8",
> -	  GL_ABGR_EXT, GL_UNSIGNED_INT_8_8_8_8, 4, 0x800000ff, 0x8000ff00 },
> -	{ "GL_ABGR_EXT/GL_UNSIGNED_INT_8_8_8_8_REV",
> -	  GL_ABGR_EXT, GL_UNSIGNED_INT_8_8_8_8_REV, 4, 0xff000080, 0x00ff0080 },
> -	{ "GL_ABGR_EXT/GL_UNSIGNED_SHORT_4_4_4_4",
> -	  GL_ABGR_EXT, GL_UNSIGNED_SHORT_4_4_4_4, 2, 0x800f, 0x80f0 },
> -	{ "GL_ABGR_EXT/GL_UNSIGNED_SHORT_4_4_4_4_REV",
> -	  GL_ABGR_EXT, GL_UNSIGNED_SHORT_4_4_4_4_REV, 2, 0xf008, 0x0f08 },
> -	{ "GL_ABGR_EXT/GL_UNSIGNED_SHORT_5_5_5_1",
> -	  GL_ABGR_EXT, GL_UNSIGNED_SHORT_5_5_5_1, 2, 0xf801, 0xf83e },
> -	{ "GL_ABGR_EXT/GL_UNSIGNED_SHORT_1_5_5_5_REV",
> -	  GL_ABGR_EXT, GL_UNSIGNED_SHORT_1_5_5_5_REV, 2, 0x800f, 0x7c0f },
> -
>  	{ "GL_RGB/GL_UNSIGNED_SHORT_5_6_5",
>  	  GL_RGB, GL_UNSIGNED_SHORT_5_6_5, 2, 0xf800, 0x7e0 },
>  	{ "GL_RGB/GL_UNSIGNED_SHORT_5_6_5_REV",
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20150113/d6ff509d/attachment.sig>