[Piglit] [PATCH] Add tests for arb_cull_distance

Tobias Klausmann tobias.johannes.klausmann at mni.thm.de
Fri Jan 16 14:54:05 PST 2015


On 16.01.2015 23:48, Dave Airlie wrote:
> On 13 January 2015 at 15:17, Tobias Klausmann
> <tobias.johannes.klausmann at mni.thm.de> wrote:
>> Testing for:
>> - new <pname> entrys supported by GetIntegerv and others
>> - new constants
>> - new array gl_CullDistance:
>>    explicit size, max. size and max. size while interfering with gl_ClipDistance
> These look good to me, do they pass against any of the other GL
> implementations of this (does anyone have one apart from nvidia beta?)
>
> The only thing I haven't done is check what other tests you should do
> for this extension, probably more execution tests are needed, but I'm
> not sure.
>
> Reviewed-by: Dave Airlie <airlied at redhat.com>

That patch series deals only with the GLSL side of the extension, 
missing parts are tests for the actual culling which i hopefully will 
gather in a second patch(series). Btw: i found a missing ; in a shader 
and will attach the patch again with that added, sorry for that...

Greetings,
Tobias


More information about the Piglit mailing list