[Piglit] [PATCH] arb_sample_shading-builtin-gl-sample-id: Use const reference.

Anuj Phogat anuj.phogat at gmail.com
Tue Jan 20 14:14:18 PST 2015


On Mon, Jan 19, 2015 at 12:43 PM, Vinson Lee <vlee at freedesktop.org> wrote:
> Fix big parameter passed by value defect reported by Coverity.
>
> Signed-off-by: Vinson Lee <vlee at freedesktop.org>
> ---
>  tests/spec/arb_sample_shading/execution/builtin-gl-sample-id.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/spec/arb_sample_shading/execution/builtin-gl-sample-id.cpp b/tests/spec/arb_sample_shading/execution/builtin-gl-sample-id.cpp
> index 739c685..e5681d4 100644
> --- a/tests/spec/arb_sample_shading/execution/builtin-gl-sample-id.cpp
> +++ b/tests/spec/arb_sample_shading/execution/builtin-gl-sample-id.cpp
> @@ -157,7 +157,7 @@ piglit_init(int argc, char **argv)
>         }
>  }
>
> -bool test_builtin_sample_id(Fbo ms_fbo)
> +bool test_builtin_sample_id(const Fbo& ms_fbo)
>  {
>         int samples;
>         bool result = true;
> --
> 2.2.1
>
> _______________________________________________
> Piglit mailing list
> Piglit at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/piglit

Reviewed-by: Anuj Phogat <anuj.phogat at gmail.com>


More information about the Piglit mailing list