[Piglit] [PATCH] arb_copy_image-targets: Add comments to silence Coverity defects.
Jason Ekstrand
jason at jlekstrand.net
Tue Jan 20 20:21:25 PST 2015
Fine with me
Reviewed-by: Jason Ekstrand <jason.ekstrand at intel.com>
On Mon, Jan 19, 2015 at 1:48 PM, Vinson Lee <vlee at freedesktop.org> wrote:
> Silence Coverity "missing break in switch" defects.
>
> Signed-off-by: Vinson Lee <vlee at freedesktop.org>
> ---
> tests/spec/arb_copy_image/targets.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tests/spec/arb_copy_image/targets.c
> b/tests/spec/arb_copy_image/targets.c
> index 86edeca..333631c 100644
> --- a/tests/spec/arb_copy_image/targets.c
> +++ b/tests/spec/arb_copy_image/targets.c
> @@ -65,12 +65,14 @@ image_init(struct image *image, GLenum target, int
> width, int height, int depth)
> switch (target) {
> case GL_TEXTURE_CUBE_MAP:
> assert(depth == 6);
> + /* Fall through. */
> case GL_TEXTURE_CUBE_MAP_ARRAY_ARB:
> assert(width == height);
> assert(depth % 6 == 0);
> break;
> case GL_TEXTURE_1D:
> assert(height == 1);
> + /* Fall through. */
> case GL_TEXTURE_2D:
> case GL_TEXTURE_RECTANGLE:
> assert(depth == 1);
> --
> 2.2.1
>
> _______________________________________________
> Piglit mailing list
> Piglit at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/piglit
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20150120/62edf02c/attachment.html>
More information about the Piglit
mailing list