[Piglit] [PATCH 1/2] update documentation to be clear about using multiple profiles

Dylan Baker baker.dylan.c at gmail.com
Mon Jan 26 06:39:32 PST 2015


On Friday, January 23, 2015 23:42:57 Emil Velikov wrote:
> On 23/01/15 20:10, Dylan Baker wrote:
> > Updates README and the help message to be clear about using multiple
> > test profiles.
> > 
> > Signed-off-by: Dylan Baker <dylanx.c.baker at intel.com>
> > ---
> >  README                    | 6 +++++-
> >  framework/programs/run.py | 6 ++++--
> >  2 files changed, 9 insertions(+), 3 deletions(-)
> > 
> > diff --git a/README b/README
> > index ef8b639..9ba0a97 100644
> > --- a/README
> > +++ b/README
> > @@ -209,11 +209,15 @@ Build from the Command Prompt.
> >  
> >  Make sure that everything is set up correctly:
> >  
> > -  $ ./piglit run tests/sanity results/sanity.results
> > +  $ ./piglit run tests/sanity results/sanity
> >  
> >  You may include '.py' on the profile, or you may exclude it (sanity vs sanity.py),
> >  both are equally valid.
> >  
> > +You may provide multiple profiles to be run at the same time:
> > +  
> > +  $ ./piglit run quick_cl gpu deqp-gles3 results/gl-cl-combined
> > +
> Hi Dylan,
> 
> Doesn't one want/need the "tests/" prefix for each profile or those are
> optional ?

The tests prefix is optional, as is the extension. Basically, when
running out of tree it doesn't make sense to have to add tests. We left
the option to use it because some developers like using tab completion

> 
> >  Use
> >  
> >    $ ./piglit run
> > diff --git a/framework/programs/run.py b/framework/programs/run.py
> > index 89ccd11..9bb4713 100644
> > --- a/framework/programs/run.py
> > +++ b/framework/programs/run.py
> > @@ -183,9 +183,11 @@ def _run_parser(input_):
> >      parser.add_argument("--test-list",
> >                          help="A file containing a list of tests to run")
> >      parser.add_argument("test_profile",
> > -                        metavar="<Path to one or more test profile(s)>",
> > +                        metavar="<Profile Path(es)",
> s/Path(es)/path(s)/ ?
> 
> Cheers,
> Emil
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20150126/beb72c16/attachment.sig>


More information about the Piglit mailing list