[Piglit] [PATCH 1/5] framework/backends/abstract.py: use next() instead of generator.next()

Timothy Arceri t_arceri at yahoo.com.au
Fri Jul 3 06:34:30 PDT 2015


For this patch

Reviewed-by: Timothy Arceri <t_arceri at yahoo.com.au>

I'm no python wizard so I don't have much to say about the other patches just
yet.

On Thu, 2015-07-02 at 16:46 -0700, Dylan Baker wrote:
> Python2.7 supports both the legacy next method, and the future looking
> next() function. We'd rather be future looking so use the next function.
> 
> Signed-off-by: Dylan Baker <dylanx.c.baker at intel.com>
> ---
>  framework/backends/abstract.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/framework/backends/abstract.py b/framework/backends/abstract.py
> index 47186f2..9da2ef8 100644
> --- a/framework/backends/abstract.py
> +++ b/framework/backends/abstract.py
> @@ -188,7 +188,7 @@ class FileBackend(Backend):
>              shutil.move(tfile, file_)
>  
>          file_ = os.path.join(self._dest, 'tests', '{}.{}'.format(
> -            self.__counter.next(), self._file_extension))
> +            next(self.__counter), self._file_extension))
>  
>          with open(file_, 'w') as f:
>              self._write(f, name, self.__INCOMPLETE)


More information about the Piglit mailing list