[Piglit] [PATCH 3/5] framwork/summary: use mako's render_unicode method instead of render

Dylan Baker baker.dylan.c at gmail.com
Mon Jul 6 16:25:36 PDT 2015

On Mon, Jul 06, 2015 at 04:18:48PM -0700, Liam Middlebrook wrote:
> I find it's generally a good idea to follow the PEP8 standard for Python 
> formatting.
> https://www.python.org/dev/peps/pep-0008/

Absolutely, and except when following PEP8 would produce odd results we
do follow PEP8, and both forms below are valid when less than 80
characters wide, although with the change from render to render_unicode
the change is required to meet the less 80 character suggestion.
> Also this change lgtm.

I think it's in the README (or maybe just the mesa README?), but we like
to see an explicit reviewed-by/tested-by/acked-by tag, so that the
author is sure what to put on the patch before pushing. Thanks.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20150706/68b5a0f5/attachment-0001.sig>

More information about the Piglit mailing list