[Piglit] [PATCH] egl-util: Define EGL_KHR_gl_colorspace symbols for older distros.

Emil Velikov emil.l.velikov at gmail.com
Fri Jul 10 02:36:09 PDT 2015


On 10 July 2015 at 09:22, Dylan Baker <baker.dylan.c at gmail.com> wrote:
> Maybe a better plan is to have the test detect that those aren't defined and
> skip?
>
I fear the proposed fix is what piglit and many others tend to do.
Here are some of the files containing such workarounds:

tests/egl/egl-configless-context.c
tests/glx/glx-buffer-age.c
tests/glx/glx-context-flush-control.c
tests/spec/ext_image_dma_buf_import/image_common.h
tests/spec/gl-3.0/api/clearbuffer-invalid-buffer.c
tests/spec/glx_mesa_query_renderer/query-renderer-common.h
tests/spec/oes_compressed_etc1_rgb8_texture/oes_compressed_etc1_rgb8_texture-basic.c
tests/util/glxew.h


A few other suggestions:
 - Check that the headers are new enough and bail out early in cmake.
Unfortunately distros may insist on keeping old headers, despite that
updating (and using) them won't cause ABI breakage.
 - Have a local copy of the headers in-tree.
Could get ugly, but many projects seems to be doing it.

I'm leaning towards the former, although feel free to use whichever you fancy.

-Emil


More information about the Piglit mailing list