[Piglit] [PATCH] arb_direct_state_access: allow tests to run with core profile

Jose Fonseca jfonseca at vmware.com
Thu Jul 16 06:25:52 PDT 2015


On 16/07/15 00:31, Brian Paul wrote:
> In Mesa, GL_ARB_direct_state_access is only available with core profile.
> But since these piglit tests didn't indicate support for core profile,
> they were skipped.
>
> With config.supports_gl_core_version = 31 piglit can create a core
> profile context and run the test.
> ---
>   tests/spec/arb_direct_state_access/get-textures.c              | 1 +
>   tests/spec/arb_direct_state_access/getcompressedtextureimage.c | 1 +
>   tests/spec/arb_direct_state_access/gettextureimage-formats.c   | 1 +
>   tests/spec/arb_direct_state_access/gettextureimage-simple.c    | 1 +
>   tests/spec/arb_direct_state_access/gettextureimage-targets.c   | 1 +
>   5 files changed, 5 insertions(+)
>
> diff --git a/tests/spec/arb_direct_state_access/get-textures.c b/tests/spec/arb_direct_state_access/get-textures.c
> index bdb021d..b6b9169 100644
> --- a/tests/spec/arb_direct_state_access/get-textures.c
> +++ b/tests/spec/arb_direct_state_access/get-textures.c
> @@ -32,6 +32,7 @@
>   PIGLIT_GL_TEST_CONFIG_BEGIN
>
>   	config.supports_gl_compat_version = 13;
> +	config.supports_gl_core_version = 31;
>
>   	config.window_visual = PIGLIT_GL_VISUAL_RGBA |
>   		PIGLIT_GL_VISUAL_DOUBLE;
> diff --git a/tests/spec/arb_direct_state_access/getcompressedtextureimage.c b/tests/spec/arb_direct_state_access/getcompressedtextureimage.c
> index dbfe0e0..8e0b7ab 100644
> --- a/tests/spec/arb_direct_state_access/getcompressedtextureimage.c
> +++ b/tests/spec/arb_direct_state_access/getcompressedtextureimage.c
> @@ -35,6 +35,7 @@ PIGLIT_GL_TEST_CONFIG_BEGIN
>
>   	config.window_width = 216;
>   	config.supports_gl_compat_version = 10;
> +	config.supports_gl_core_version = 31;
>
>   	config.window_visual = PIGLIT_GL_VISUAL_RGBA |
>   			       PIGLIT_GL_VISUAL_DOUBLE;
> diff --git a/tests/spec/arb_direct_state_access/gettextureimage-formats.c b/tests/spec/arb_direct_state_access/gettextureimage-formats.c
> index e2d637c..c9c529d 100644
> --- a/tests/spec/arb_direct_state_access/gettextureimage-formats.c
> +++ b/tests/spec/arb_direct_state_access/gettextureimage-formats.c
> @@ -42,6 +42,7 @@
>   PIGLIT_GL_TEST_CONFIG_BEGIN
>
>   	config.supports_gl_compat_version = 10;
> +	config.supports_gl_core_version = 31;
>
>   	config.window_width = 600;
>   	config.window_height = 200;
> diff --git a/tests/spec/arb_direct_state_access/gettextureimage-simple.c b/tests/spec/arb_direct_state_access/gettextureimage-simple.c
> index c432f8c..4dfd326 100644
> --- a/tests/spec/arb_direct_state_access/gettextureimage-simple.c
> +++ b/tests/spec/arb_direct_state_access/gettextureimage-simple.c
> @@ -18,6 +18,7 @@
>   PIGLIT_GL_TEST_CONFIG_BEGIN
>
>   	config.supports_gl_compat_version = 10;
> +	config.supports_gl_core_version = 31;
>
>   	config.window_visual = PIGLIT_GL_VISUAL_RGB | PIGLIT_GL_VISUAL_DOUBLE;
>
> diff --git a/tests/spec/arb_direct_state_access/gettextureimage-targets.c b/tests/spec/arb_direct_state_access/gettextureimage-targets.c
> index 7f5c51e..42937a1 100644
> --- a/tests/spec/arb_direct_state_access/gettextureimage-targets.c
> +++ b/tests/spec/arb_direct_state_access/gettextureimage-targets.c
> @@ -34,6 +34,7 @@
>   PIGLIT_GL_TEST_CONFIG_BEGIN
>
>   	config.supports_gl_compat_version = 10;
> +	config.supports_gl_core_version = 31;
>
>   	config.window_visual = PIGLIT_GL_VISUAL_RGBA |
>   			       PIGLIT_GL_VISUAL_DOUBLE;
>

Reviewed-by: Jose Fonseca <jfonseca at vmware.com>


More information about the Piglit mailing list