[Piglit] [PATCH] arb_transform_feedback3: test for an incorrect assert in mesa/st

[Marek Olšák]

On Thu, Jul 30, 2015 at 2:52 AM, Dave Airlie <airlied at gmail.com> wrote:
> From: Dave Airlie <airlied at redhat.com>
>
> This test hits an assert in the state tracker from the API.
>
> Signed-off-by: Dave Airlie <airlied at redhat.com>
> ---
>  .../spec/arb_transform_feedback3/CMakeLists.gl.txt |  2 +-
>  tests/spec/arb_transform_feedback3/begin_end.c     | 78 ++++++++++++++++++++++
>  2 files changed, 79 insertions(+), 1 deletion(-)
>  create mode 100644 tests/spec/arb_transform_feedback3/begin_end.c
>
> diff --git a/tests/spec/arb_transform_feedback3/CMakeLists.gl.txt b/tests/spec/arb_transform_feedback3/CMakeLists.gl.txt
> index 56bf74b..5d93563 100644
> --- a/tests/spec/arb_transform_feedback3/CMakeLists.gl.txt
> +++ b/tests/spec/arb_transform_feedback3/CMakeLists.gl.txt
> @@ -15,5 +15,5 @@ piglit_add_executable (arb_transform_feedback3-draw_using_invalid_stream_index d
>  piglit_add_executable (arb_transform_feedback3-set_varyings_with_invalid_args set_varyings_with_invalid_args.c)
>  piglit_add_executable (arb_transform_feedback3-set_invalid_varyings set_invalid_varyings.c)
>  piglit_add_executable (arb_transform_feedback3-ext_interleaved_two_bufs ext_interleaved_two_bufs.c)
> -
> +piglit_add_executable (arb_transform_feedback3-begin_end begin_end.c)
>  # vim: ft=cmake:
> diff --git a/tests/spec/arb_transform_feedback3/begin_end.c b/tests/spec/arb_transform_feedback3/begin_end.c
> new file mode 100644
> index 0000000..8cedf87
> --- /dev/null
> +++ b/tests/spec/arb_transform_feedback3/begin_end.c
> @@ -0,0 +1,78 @@
> +/*
> + * Copyright © 2013 Intel Corporation
> + *
> + * Permission is hereby granted, free of charge, to any person obtaining a
> + * copy of this software and associated documentation files (the "Software"),
> + * to deal in the Software without restriction, including without limitation
> + * the rights to use, copy, modify, merge, publish, distribute, sublicense,
> + * and/or sell copies of the Software, and to permit persons to whom the
> + * Software is furnished to do so, subject to the following conditions:
> + *
> + * The above copyright notice and this permission notice (including the next
> + * paragraph) shall be included in all copies or substantial portions of the
> + * Software.
> + *
> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
> + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
> + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
> + * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
> + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
> + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
> + * IN THE SOFTWARE.
> + */
> +
> +#include "piglit-util-gl.h"
> +#include "xfb3_common.h"
> +
> +/**
> + * @file begin_end.c
> + *
> + * This tests for a bug in the gallium state tracker which asserted with
> + * state_tracker/st_cb_xformfb.c:194: st_transform_feedback_get_draw_target: Assertion `0' failed.
> + * This was being hit by ogl conform as well.
> + */
> +
> +PIGLIT_GL_TEST_CONFIG_BEGIN
> +
> +       config.supports_gl_compat_version = 32;
> +       config.supports_gl_core_version = 32;
> +
> +PIGLIT_GL_TEST_CONFIG_END
> +
> +void
> +piglit_init(int argc, char **argv)
> +{
> +       bool pass = true;
> +       GLuint prog;
> +       GLint max_attrib_n;
> +       GLuint buffer;
> +       const char * outputVaryings[] = {"gl_Position"};
> +       piglit_require_extension("GL_ARB_transform_feedback3");
> +
> +       glGetIntegerv(GL_MAX_TRANSFORM_FEEDBACK_SEPARATE_ATTRIBS,
> +               &max_attrib_n);
> +       if (!max_attrib_n) {
> +               printf("Maximum number of separete attributes is zero\n");
> +               piglit_report_result(PIGLIT_FAIL);
> +       }

What's the point of this if the test doesn't use separate attribs?
Also, there are minimum requirements on the number of buffers.

Other than that:

Reviewed-by: Marek Olšák <marek.olsak at amd.com>

Marek