[Piglit] [PATCH] tests: add missing requirements to two arb_arrays_of_arrays tests

Ilia Mirkin imirkin at alum.mit.edu
Thu Jul 30 09:41:43 PDT 2015


Reviewed-by: Ilia Mirkin <imirkin at alum.mit.edu>

Hopefully the failure is a message along the lines of "arrays of
arrays isn't supported". If the failure is something more subtle, it'd
be nice to have a negative compilation test case for the AoA extension
when it's not enabled.

  -ilia


On Thu, Jul 30, 2015 at 12:25 PM, Dylan Baker <baker.dylan.c at gmail.com> wrote:
> These two tests currently fail on i965 because they don't check for the
> proper requirements. This patch adds them.
>
> cc: Timothy Arceri <t_arceri at yahoo.com.au>
> Signed-off-by: Dylan Baker <dylanx.c.baker at intel.com>
> ---
>  .../execution/sampler/fs-struct-non-const-index-const-index.shader_test | 2 ++
>  .../fs-struct-non-const-index-sampler-non-const-index.shader_test       | 2 ++
>  2 files changed, 4 insertions(+)
>
> diff --git a/tests/spec/arb_arrays_of_arrays/execution/sampler/fs-struct-non-const-index-const-index.shader_test b/tests/spec/arb_arrays_of_arrays/execution/sampler/fs-struct-non-const-index-const-index.shader_test
> index 0eeb7ee..a877248 100644
> --- a/tests/spec/arb_arrays_of_arrays/execution/sampler/fs-struct-non-const-index-const-index.shader_test
> +++ b/tests/spec/arb_arrays_of_arrays/execution/sampler/fs-struct-non-const-index-const-index.shader_test
> @@ -4,12 +4,14 @@
>  [require]
>  GLSL >= 1.50
>  GL_ARB_gpu_shader5
> +GL_ARB_arrays_of_arrays
>
>  [vertex shader passthrough]
>
>  [fragment shader]
>  #version 150
>  #extension GL_ARB_gpu_shader5: require
> +#extension GL_ARB_arrays_of_arrays: require
>
>  struct S {
>     sampler2D tex[2];
> diff --git a/tests/spec/arb_arrays_of_arrays/execution/sampler/fs-struct-non-const-index-sampler-non-const-index.shader_test b/tests/spec/arb_arrays_of_arrays/execution/sampler/fs-struct-non-const-index-sampler-non-const-index.shader_test
> index d8edf65..248b812 100644
> --- a/tests/spec/arb_arrays_of_arrays/execution/sampler/fs-struct-non-const-index-sampler-non-const-index.shader_test
> +++ b/tests/spec/arb_arrays_of_arrays/execution/sampler/fs-struct-non-const-index-sampler-non-const-index.shader_test
> @@ -4,12 +4,14 @@
>  [require]
>  GLSL >= 1.50
>  GL_ARB_gpu_shader5
> +GL_ARB_arrays_of_arrays
>
>  [vertex shader passthrough]
>
>  [fragment shader]
>  #version 150
>  #extension GL_ARB_gpu_shader5: require
> +#extension GL_ARB_arrays_of_arrays: require
>
>  struct S {
>     sampler2D tex[2];
> --
> 2.4.6
>
> _______________________________________________
> Piglit mailing list
> Piglit at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/piglit


More information about the Piglit mailing list