[Piglit] [PATCH 00/13] Add more arb_shader_storage_buffer_object tests

[Jordan Justen]

On 2015-05-13 23:17:12, Samuel Iglesias Gonsalvez wrote:
> This patchset adds piglit tests for arb_shader_storage_buffer_object
> extension.
> 
> They are also available on this repository:
> 
> $ git clone -b arb_shader_storage_buffer_object-v1 \
>   https://github.com/Igalia/piglit.git
> 
> Thanks,
> 
> Sam
> 
> Samuel Iglesias Gonsalvez (13):
>   arb_shader_storage_buffer_object: Add preprocessor tests
>   arb_shader_storage_buffer_object: add compiler tests
>   arb_shader_storage_buffer_object: Add linker tests
>   arb_shader_storage_buffer: Add rendering test
>   arb_shader_storage_buffer_object: add test for
>     GL_MAX_SHADER_STORAGE_BUFFER_SIZE
>   arb_shader_storage_buffer_object: add test to check glGetIntegeri_v()
>     queries
>   arb_shader_storage_buffer_object: Add new test for glDeleteBuffers()
>     behavior
>   arb_shader_storage_buffer_object: Add test to check maximum number of
>     allowed SSBOs
>   arb_shader_storage_buffer_object: New test for setting/getting block
>     bindings.
>   arb_shader_storage_buffer_object: Add test for setting binding point
>     to an array of SSBOs
>   arb_shader_storage_buffer_object: add test to check SSBO writes with
>     layout(std430)
>   arb_shader_storage_buffer_object: add test to check SSBO writes with
>     layout(std140)
>   arb_shader_storage_buffer_object: Add test for buffer variable queries
> 
>  tests/all.py                                       |  21 ++
>  .../CMakeLists.gl.txt                              |  10 +
>  .../array-ssbo-binding.c                           | 149 +++++++++
>  .../extension-disabled-shader-storage-block.frag   |  15 +
>  .../compiler/extension-disabled-std430.frag        |  13 +
>  .../compiler/layout-std430-non-shader-storage.frag |  24 ++
>  .../compiler/layout-std430-within-block.frag       |  22 ++
>  .../compiler/shader-storage-block-initializer.frag |  21 ++
>  .../compiler/shader-storage-block-sampler.frag     |  23 ++
>  .../compiler/shader-storage-outside-block.frag     |  20 ++
>  .../compiler/unsized-array-argument-function.frag  |  29 ++
>  .../unsized-array-not-in-last-position.frag        |  24 ++
>  .../deletebuffers.c                                | 105 ++++++
>  .../getintegeri_v.c                                | 120 +++++++
>  .../layout-std140-write-shader.c                   | 161 +++++++++
>  .../layout-std430-write-shader.c                   | 185 +++++++++++
>  ...hader-storage-block-different-def-2.shader_test |  40 +++
>  ...hader-storage-block-different-def-3.shader_test |  40 +++
>  .../shader-storage-block-different-def.shader_test |  38 +++
>  ...shader-storage-block-different-size.shader_test |  41 +++
>  .../arb_shader_storage_buffer_object/maxblocks.c   | 358 +++++++++++++++++++++
>  .../maxshaderstorageblocksize.c                    | 240 ++++++++++++++
>  .../preprocessor/define.frag                       |  19 ++
>  .../preprocessor/define.vert                       |  19 ++
>  .../program-interface-query.c                      | 166 ++++++++++
>  .../arb_shader_storage_buffer_object/rendering.c   | 232 +++++++++++++
>  .../shaderstorageblockbinding.c                    | 125 +++++++
>  27 files changed, 2260 insertions(+)
>  create mode 100644 tests/spec/arb_shader_storage_buffer_object/array-ssbo-binding.c
>  create mode 100644 tests/spec/arb_shader_storage_buffer_object/compiler/extension-disabled-shader-storage-block.frag
>  create mode 100644 tests/spec/arb_shader_storage_buffer_object/compiler/extension-disabled-std430.frag
>  create mode 100644 tests/spec/arb_shader_storage_buffer_object/compiler/layout-std430-non-shader-storage.frag
>  create mode 100644 tests/spec/arb_shader_storage_buffer_object/compiler/layout-std430-within-block.frag
>  create mode 100644 tests/spec/arb_shader_storage_buffer_object/compiler/shader-storage-block-initializer.frag
>  create mode 100644 tests/spec/arb_shader_storage_buffer_object/compiler/shader-storage-block-sampler.frag
>  create mode 100644 tests/spec/arb_shader_storage_buffer_object/compiler/shader-storage-outside-block.frag
>  create mode 100644 tests/spec/arb_shader_storage_buffer_object/compiler/unsized-array-argument-function.frag
>  create mode 100644 tests/spec/arb_shader_storage_buffer_object/compiler/unsized-array-not-in-last-position.frag
>  create mode 100644 tests/spec/arb_shader_storage_buffer_object/deletebuffers.c
>  create mode 100644 tests/spec/arb_shader_storage_buffer_object/getintegeri_v.c
>  create mode 100644 tests/spec/arb_shader_storage_buffer_object/layout-std140-write-shader.c
>  create mode 100644 tests/spec/arb_shader_storage_buffer_object/layout-std430-write-shader.c
>  create mode 100644 tests/spec/arb_shader_storage_buffer_object/linker/shader-storage-block-different-def-2.shader_test
>  create mode 100644 tests/spec/arb_shader_storage_buffer_object/linker/shader-storage-block-different-def-3.shader_test
>  create mode 100644 tests/spec/arb_shader_storage_buffer_object/linker/shader-storage-block-different-def.shader_test
>  create mode 100644 tests/spec/arb_shader_storage_buffer_object/linker/shader-storage-block-different-size.shader_test
>  create mode 100644 tests/spec/arb_shader_storage_buffer_object/maxblocks.c
>  create mode 100644 tests/spec/arb_shader_storage_buffer_object/maxshaderstorageblocksize.c

seems a bit run-on name wise. max-ssbo-size.c?

>  create mode 100644 tests/spec/arb_shader_storage_buffer_object/preprocessor/define.frag
>  create mode 100644 tests/spec/arb_shader_storage_buffer_object/preprocessor/define.vert
>  create mode 100644 tests/spec/arb_shader_storage_buffer_object/program-interface-query.c
>  create mode 100644 tests/spec/arb_shader_storage_buffer_object/rendering.c
>  create mode 100644 tests/spec/arb_shader_storage_buffer_object/shaderstorageblockbinding.c

similar?

These patches seemed to have survived past the 2-weeks with no naks
rule. Thus, you could just push them if you feel pretty good about
them.

Did you test these on a driver that already implements ssbos? (Other
than your mesa work. :)

If so,
Acked-by: Jordan Justen <jordan.l.justen at intel.com>