[Piglit] [PATCH] arb_uniform_buffer_object: fix UNIFORM_BUFFER_START and UNIFORM_BUFFER_SIZE queries when no buffer object is bound

Samuel Iglesias Gonsálvez siglesias at igalia.com
Mon Jun 8 00:31:29 PDT 2015


I plan to push this patch at the end of this week if no complains.

Sam

On 14/05/15 08:56, Samuel Iglesias Gonsalvez wrote:
> According to ARB_uniform_buffer_object spec:
> 
>     "If the parameter (starting offset or size) was not specified when the
>      buffer object was bound (e.g. if bound with BindBufferBase), or if no
>      buffer object is bound to <index>, zero is returned."
> 
> Tested on NVIDIA's proprietary driver version 340.65 and ATI proprietary
> driver version 13.35.1005.
> 
> Signed-off-by: Samuel Iglesias Gonsalvez <siglesias at igalia.com>
> ---
>  tests/spec/arb_uniform_buffer_object/getintegeri_v.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/spec/arb_uniform_buffer_object/getintegeri_v.c b/tests/spec/arb_uniform_buffer_object/getintegeri_v.c
> index d1b685f..9ed5fcc 100644
> --- a/tests/spec/arb_uniform_buffer_object/getintegeri_v.c
> +++ b/tests/spec/arb_uniform_buffer_object/getintegeri_v.c
> @@ -79,7 +79,7 @@ piglit_init(int argc, char **argv)
>  
>  	piglit_require_extension("GL_ARB_uniform_buffer_object");
>  
> -	test_range(__LINE__, 0, 0, -1, -1);
> +	test_range(__LINE__, 0, 0, 0, 0);
>  
>  	glGetIntegerv(GL_UNIFORM_BUFFER_OFFSET_ALIGNMENT, &alignment);
>  
> @@ -117,7 +117,7 @@ piglit_init(int argc, char **argv)
>  	 * of the GL API, including glBindBuffer(), to allow it
>  	 */
>  	glBindBufferBase(GL_UNIFORM_BUFFER, 0, 0);
> -	test_range(__LINE__, 0, 0, -1, -1);
> +	test_range(__LINE__, 0, 0, 0, 0);
>  
>  	/* Test the error condition. */
>  	glGetIntegerv(GL_MAX_UNIFORM_BUFFER_BINDINGS, &max_bindings);
> 


More information about the Piglit mailing list