[Piglit] [PATCH] ext_framebuffer_blit: try blitting *very* early on in the application

[Tapani Pälli]

On 06/26/2015 03:55 AM, Ilia Mirkin wrote:
> This crashes on current mesa.

(test passes on i965)

Reviewed-by: Tapani Pälli <tapani.palli at intel.com>

> Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu>
> ---
>   tests/all.py                                      |  5 +++
>   tests/spec/CMakeLists.txt                         |  1 +
>   tests/spec/ext_framebuffer_blit/CMakeLists.gl.txt | 12 +++++
>   tests/spec/ext_framebuffer_blit/CMakeLists.txt    |  1 +
>   tests/spec/ext_framebuffer_blit/blit-early.c      | 55 +++++++++++++++++++++++
>   5 files changed, 74 insertions(+)
>   create mode 100644 tests/spec/ext_framebuffer_blit/CMakeLists.gl.txt
>   create mode 100644 tests/spec/ext_framebuffer_blit/CMakeLists.txt
>   create mode 100644 tests/spec/ext_framebuffer_blit/blit-early.c
>
> diff --git a/tests/all.py b/tests/all.py
> index 6c4fb41..0b135b7 100644
> --- a/tests/all.py
> +++ b/tests/all.py
> @@ -4355,5 +4355,10 @@ with profile.group_manager(
>       g(['arb_vertex_attrib_64bit-double_attribs'], 'double_attribs')
>       g(['arb_vertex_attrib_64bit-check-explicit-location'], 'check-explicit-location')
>
> +with profile.group_manager(
> +        PiglitGLTest,
> +        grouptools.join('spec', 'ext_framebuffer_blit')) as g:
> +    g(['ext_framebuffer_blit-blit-early'], 'blit-early')
> +
>   if platform.system() is 'Windows':
>       profile.filter_tests(lambda p, _: not p.startswith('glx'))
> diff --git a/tests/spec/CMakeLists.txt b/tests/spec/CMakeLists.txt
> index e009349..d673340 100644
> --- a/tests/spec/CMakeLists.txt
> +++ b/tests/spec/CMakeLists.txt
> @@ -129,3 +129,4 @@ add_subdirectory (ext_polygon_offset_clamp)
>   add_subdirectory (arb_pipeline_statistics_query)
>   add_subdirectory (arb_texture_stencil8)
>   add_subdirectory (arb_vertex_attrib_64bit)
> +add_subdirectory (ext_framebuffer_blit)
> diff --git a/tests/spec/ext_framebuffer_blit/CMakeLists.gl.txt b/tests/spec/ext_framebuffer_blit/CMakeLists.gl.txt
> new file mode 100644
> index 0000000..e0a5f5b
> --- /dev/null
> +++ b/tests/spec/ext_framebuffer_blit/CMakeLists.gl.txt
> @@ -0,0 +1,12 @@
> +include_directories(
> +	${GLEXT_INCLUDE_DIR}
> +	${OPENGL_INCLUDE_PATH}
> +)
> +
> +link_libraries (
> +	piglitutil_${piglit_target_api}
> +	${OPENGL_gl_LIBRARY}
> +	${OPENGL_glu_LIBRARY}
> +)
> +
> +piglit_add_executable (ext_framebuffer_blit-blit-early blit-early.c)
> diff --git a/tests/spec/ext_framebuffer_blit/CMakeLists.txt b/tests/spec/ext_framebuffer_blit/CMakeLists.txt
> new file mode 100644
> index 0000000..144a306
> --- /dev/null
> +++ b/tests/spec/ext_framebuffer_blit/CMakeLists.txt
> @@ -0,0 +1 @@
> +piglit_include_target_api()
> diff --git a/tests/spec/ext_framebuffer_blit/blit-early.c b/tests/spec/ext_framebuffer_blit/blit-early.c
> new file mode 100644
> index 0000000..e662348
> --- /dev/null
> +++ b/tests/spec/ext_framebuffer_blit/blit-early.c
> @@ -0,0 +1,55 @@
> +/*
> + * Copyright (c) 2015 Ilia Mirkin
> + *
> + * Permission is hereby granted, free of charge, to any person obtaining a
> + * copy of this software and associated documentation files (the "Software"),
> + * to deal in the Software without restriction, including without limitation
> + * the rights to use, copy, modify, merge, publish, distribute, sublicense,
> + * and/or sell copies of the Software, and to permit persons to whom the
> + * Software is furnished to do so, subject to the following conditions:
> + *
> + * The above copyright notice and this permission notice (including the next
> + * paragraph) shall be included in all copies or substantial portions of the
> + * Software.
> + *
> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
> + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
> + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
> + * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
> + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
> + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
> + * IN THE SOFTWARE.
> + */
> +
> +#include "piglit-util-gl.h"
> +
> +PIGLIT_GL_TEST_CONFIG_BEGIN
> +
> +        config.supports_gl_compat_version = 11;
> +
> +        config.window_visual = PIGLIT_GL_VISUAL_DOUBLE | PIGLIT_GL_VISUAL_RGBA;
> +
> +PIGLIT_GL_TEST_CONFIG_END
> +
> +enum piglit_result
> +piglit_display(void)
> +{
> +        /* UNREACHED */
> +        return PIGLIT_FAIL;
> +}
> +
> +void
> +piglit_init(int argc, char **argv)
> +{
> +	if (!piglit_is_extension_supported("GL_EXT_framebuffer_blit") &&
> +	    piglit_get_gl_version() < 30)
> +		piglit_report_result(PIGLIT_SKIP);
> +
> +	glBlitFramebuffer(0, 0, 1, 1, 0, 0, 1, 1,
> +			  GL_COLOR_BUFFER_BIT, GL_NEAREST);
> +
> +	if (piglit_check_gl_error(GL_NO_ERROR))
> +		piglit_report_result(PIGLIT_PASS);
> +	else
> +		piglit_report_result(PIGLIT_FAIL);
> +}
>