[Piglit] [PATCH] Ignore piglit warning status in JUnit
daniel at ffwll.ch
Fri Jun 26 11:27:42 PDT 2015
On Fri, Jun 26, 2015 at 10:40:28AM -0700, Mark Janes wrote:
> JUnit has no concept of "warning". It supports the following
> - skip
> - success
> - fail
> - error
> dEQP has been found to intermittently emit warnings for passed tests,
> and this status is accurately represented in piglit json. However,
> current JUnit transforms them into failures.
Isn't that something the dEQP runner should take care of? If warnings
aren't valid there, then just don't flag any test results as warning. At
least for other cases I'd count gpu hangs in dmesg very much as a failure.
Hence this result frobbing shouldn't be done here imo.
> A test which emits a warning is more accurately represented as
> "success" in JUnit.
> framework/backends/junit.py | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
> diff --git a/framework/backends/junit.py b/framework/backends/junit.py
> index 632e516..7499829 100644
> --- a/framework/backends/junit.py
> +++ b/framework/backends/junit.py
> @@ -142,8 +142,7 @@ class JUnitBackend(FileBackend):
> if data['result'] == 'skip':
> res = etree.SubElement(element, 'skipped')
> - elif data['result'] in ['warn', 'fail', 'dmesg-warn',
> - 'dmesg-fail']:
> + elif data['result'] in ['fail', 'dmesg-fail']:
> if expected_result == "failure":
> err.text += "\n\nWARN: passing test as an expected failure"
> res = etree.SubElement(element, 'skipped',
> Piglit mailing list
> Piglit at lists.freedesktop.org
Software Engineer, Intel Corporation
More information about the Piglit