[Piglit] [PATCH] Interpret dEQP "QualityWarning" as pass

Ilia Mirkin imirkin at alum.mit.edu
Fri Jun 26 12:00:01 PDT 2015


On Fri, Jun 26, 2015 at 2:44 PM, Dylan Baker <baker.dylan.c at gmail.com> wrote:
>> That's fine, but then that's the justification, not "junit interprets
>> warn as fail". Note that some (regular) piglit tests will also emit
>> "warn", and they don't mean "fail". I believe that junit needs to be
>> fixed to not interpret warn as fail irrespective of what happens in
>> deqp. But for the record, I don't use junit.
>>
>> I'm not sure how I feel about the "warn" output in piglit in general,
>> it seems a bit weird. Bogus and intermittent warnings certainly sound
>> like a problem, and perhaps that's reason enough to just ignore them.
>
> I'm fine with either solution.
>
> Warn is kind of an odd status. Basically if a test passes, but there is
> anything unexpected in stderr, the test will get marked warn. (I think
> some other suites use it differently, maybe igt?)

Well, with the GL suite, a test can on its own decide to return a
"warn" status. The framework doesn't automatically add that in (or at
least didn't before).

  -ilia


More information about the Piglit mailing list