[Piglit] [PATCH v2] Ignore piglit warning status in JUnit

Dylan Baker baker.dylan.c at gmail.com
Sat Jun 27 16:55:20 PDT 2015


I don't have the full sources here, but assuming that warm will become
pass, you can add my reviewed-by
On Jun 26, 2015 3:35 PM, "Ilia Mirkin" <imirkin at alum.mit.edu> wrote:

> Reviewed-by: Ilia Mirkin <imirkin at alum.mit.edu>
>
> On Fri, Jun 26, 2015 at 6:35 PM, Mark Janes <mark.a.janes at intel.com>
> wrote:
> > JUnit has no concept of "warning".  It supports the following
> > statuses:
> >
> >  - skip
> >  - success
> >  - fail
> >  - error
> >
> > A test which emits a warning is more accurately represented as
> > "success" in JUnit.
> >
> > v2: Continue to report failure for "dmesg-warn", which is more serious
> >     than "warn".  (from Ilia Mirkin)
> > ---
> >  framework/backends/junit.py | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/framework/backends/junit.py b/framework/backends/junit.py
> > index 632e516..8c8639e 100644
> > --- a/framework/backends/junit.py
> > +++ b/framework/backends/junit.py
> > @@ -142,8 +142,7 @@ class JUnitBackend(FileBackend):
> >              if data['result'] == 'skip':
> >                  res = etree.SubElement(element, 'skipped')
> >
> > -            elif data['result'] in ['warn', 'fail', 'dmesg-warn',
> > -                                    'dmesg-fail']:
> > +            elif data['result'] in ['fail', 'dmesg-warn', 'dmesg-fail']:
> >                  if expected_result == "failure":
> >                      err.text += "\n\nWARN: passing test as an expected
> failure"
> >                      res = etree.SubElement(element, 'skipped',
> > --
> > 2.1.4
> >
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20150627/d0c58348/attachment.html>


More information about the Piglit mailing list