[Piglit] [PATCH v2] arb_direct_state_access: fix the execution of two tests

Laura Ekstrand laura at jlekstrand.net
Tue Mar 3 13:20:22 PST 2015


Sorry, I had a misunderstanding earlier in the year about which compression
formats to test.  The argument to compressedtextureimage should be changed
to GL_COMPRESSED_RGBA_S3TC_DXT5_EXT.  I will send a patch for this.

Thanks.

Laura

On Mon, Mar 2, 2015 at 3:12 AM, Martin Peres <martin.peres at linux.intel.com>
wrote:

> The problem was in all.py where the argument was not specified as an array
> but rather in the same string as the binary's path..
>
> v2: Review from Ilia Mirkin
> - Get rid of some debugging left-overs
> - remove an extra space
>
> Signed-off-by: Martin Peres <martin.peres at linux.intel.com>
> ---
>  tests/all.py | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/all.py b/tests/all.py
> index 0738de7..a47d2b5 100644
> --- a/tests/all.py
> +++ b/tests/all.py
> @@ -4008,11 +4008,11 @@
> spec['ARB_direct_state_access']['copytexturesubimage'] =
> PiglitGLTest(['arb_dire
>  spec['ARB_direct_state_access']['texture-errors'] =
> PiglitGLTest(['arb_direct_state_access-texture-errors'],
> run_concurrent=True)
>  spec['ARB_direct_state_access']['get-textures'] =
> PiglitGLTest(['arb_direct_state_access-get-textures'], run_concurrent=True)
>  spec['ARB_direct_state_access']['gettextureimage-formats'] =
> PiglitGLTest(['arb_direct_state_access-gettextureimage-formats'],
> run_concurrent=True)
> -spec['ARB_direct_state_access']['gettextureimage-formats'] =
> PiglitGLTest(['arb_direct_state_access-gettextureimage-formats
> init-by-rendering'], run_concurrent=True)
> +spec['ARB_direct_state_access']['gettextureimage-formats'] =
> PiglitGLTest(['arb_direct_state_access-gettextureimage-formats',
> 'init-by-rendering'], run_concurrent=True)
>  spec['ARB_direct_state_access']['gettextureimage-luminance'] =
> PiglitGLTest(['arb_direct_state_access-gettextureimage-luminance'],
> run_concurrent=True)
>  spec['ARB_direct_state_access']['gettextureimage-simple'] =
> PiglitGLTest(['arb_direct_state_access-gettextureimage-simple'],
> run_concurrent=True)
>  spec['ARB_direct_state_access']['gettextureimage-targets'] =
> PiglitGLTest(['arb_direct_state_access-gettextureimage-targets'],
> run_concurrent=True)
> -spec['ARB_direct_state_access']['compressedtextureimage'] =
> PiglitGLTest(['arb_direct_state_access-compressedtextureimage
> GL_COMPRESSED_RGBA_FXT1_3DFX'], run_concurrent=True)
> +spec['ARB_direct_state_access']['compressedtextureimage'] =
> PiglitGLTest(['arb_direct_state_access-compressedtextureimage',
> 'GL_COMPRESSED_RGBA_FXT1_3DFX'], run_concurrent=True)
>  spec['ARB_direct_state_access']['getcompressedtextureimage'] =
> PiglitGLTest(['arb_direct_state_access-getcompressedtextureimage'],
> run_concurrent=True)
>  spec['ARB_direct_state_access']['texture-storage-multisample'] =
> PiglitGLTest(['arb_direct_state_access-texture-storage-multisample'],
> run_concurrent=True)
>  spec['ARB_direct_state_access']['texture-buffer'] =
> PiglitGLTest(['arb_direct_state_access-texture-buffer'],
> run_concurrent=True)
> --
> 2.3.1
>
> _______________________________________________
> Piglit mailing list
> Piglit at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/piglit
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20150303/5a79113a/attachment-0001.html>


More information about the Piglit mailing list