[Piglit] [PATCH] Delete redundant condition-07.vert test.

Jordan Justen jordan.l.justen at intel.com
Fri Mar 6 09:18:07 PST 2015


Reviewed-by: Jordan Justen <jordan.l.justen at intel.com>

On 2015-03-05 23:22:52, Kenneth Graunke wrote:
> This test is redundant with:
> glsl-1.20/compiler/structure-and-array-operations/array-selection.vert
> 
> Both contain the same shader code and the same spec citation - the only
> difference is variable names and the exact portion of the text quoted.
> 
> The other one has a better name, so keep it and delete condition-07.
> ---
>  tests/glslparsertest/glsl2/condition-07.vert | 26 --------------------------
>  1 file changed, 26 deletions(-)
>  delete mode 100644 tests/glslparsertest/glsl2/condition-07.vert
> 
> diff --git a/tests/glslparsertest/glsl2/condition-07.vert b/tests/glslparsertest/glsl2/condition-07.vert
> deleted file mode 100644
> index 189c493..0000000
> --- a/tests/glslparsertest/glsl2/condition-07.vert
> +++ /dev/null
> @@ -1,26 +0,0 @@
> -// [config]
> -// expect_result: pass
> -// glsl_version: 1.20
> -//
> -// [end config]
> -
> -/* PASS
> - *
> - * From page 38 (page 44 of the PDF) of the GLSL 1.20 spec:
> - *
> - *    "The second and third expressions can be any type, as long their types
> - *    match, or there is a conversion in Section 4.1.10 "Implicit Conversions"
> - *    that can be applied to one of the expressions to make their types
> - *    match."
> - */
> -#version 120
> -
> -uniform bool selector;
> -uniform vec4 a[2];
> -uniform vec4 b[2];
> -uniform int idx;
> -
> -void main()
> -{
> -  gl_Position = (selector ? a : b)[idx];
> -}
> -- 
> 2.2.2
> 
> _______________________________________________
> Piglit mailing list
> Piglit at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/piglit


More information about the Piglit mailing list