[Piglit] [Patch v3 1/8] igt.py: Fix whitepace warnings for pylint

[Thomas Wood]

On 6 March 2015 at 18:45, Dylan Baker <baker.dylan.c at gmail.com> wrote:
> On Fri, Mar 06, 2015 at 05:20:37PM +0000, Thomas Wood wrote:
>> On 5 March 2015 at 18:19, Dylan Baker <baker.dylan.c at gmail.com> wrote:
>> > Hey Thomas, did you have any more comments on this series, or is it good
>> > to land? I ask because I'm working on python3 porting, an landing this
>> > will make a lot of that work easier.
>>
>> Apart from a small fix to patch 4, the series looks good to me.
>
> Is that an rb?

Sure, with the fix for patch 4, the whole series is:

Reviewed-by: Thomas Wood <thomas.wood at intel.com>

>
>>
>>
>> >
>> > Dylan
>> >
>> > On Wed, Jan 28, 2015 at 11:35:01AM -0800, Dylan Baker wrote:
>> >> v2: - Also remove stderr from subprocess.Popen
>> >>
>> >> Signed-off-by: Dylan Baker <dylanx.c.baker at intel.com>
>> >> ---
>> >>  tests/igt.py | 20 +++++++++-----------
>> >>  1 file changed, 9 insertions(+), 11 deletions(-)
>> >>
>> >> diff --git a/tests/igt.py b/tests/igt.py
>> >> index bd4c70e..d54bb65 100644
>> >> --- a/tests/igt.py
>> >> +++ b/tests/igt.py
>> >> @@ -124,22 +124,20 @@ tests.extend(listTests("multi-tests"))
>> >>
>> >>  def addSubTestCases(test):
>> >>      proc = subprocess.Popen(
>> >> -            [os.path.join(igtTestRoot, test), '--list-subtests'],
>> >> -            stdout=subprocess.PIPE,
>> >> -            stderr=subprocess.PIPE,
>> >> -            env=os.environ.copy(),
>> >> -            universal_newlines=True
>> >> -            )
>> >> -    out, err = proc.communicate()
>> >> +        [os.path.join(igtTestRoot, test), '--list-subtests'],
>> >> +        stdout=subprocess.PIPE,
>> >> +        env=os.environ.copy(),
>> >> +        universal_newlines=True)
>> >> +    out, _ = proc.communicate()
>> >>
>> >>      # a return code of 79 indicates there are no subtests
>> >>      if proc.returncode == 79:
>> >> -         profile.test_list[grouptools.join('igt', test)] = IGTTest(test)
>> >> -         return
>> >> +        profile.test_list[grouptools.join('igt', test)] = IGTTest(test)
>> >> +        return
>> >>
>> >>      if proc.returncode != 0:
>> >> -         print "Error: Could not list subtests for " + test
>> >> -         return
>> >> +        print "Error: Could not list subtests for " + test
>> >> +        return
>> >>
>> >>      subtests = out.split("\n")
>> >>
>> >> --
>> >> 2.2.2
>> >>