[Piglit] [PATCH] deqp_gles3.py: Fix PEP 8 issues.

[Dylan Baker]

I have one comment, with that fixed:
Reviewed-by: Dylan Baker <baker.dylan.c at gmail.com>

On Sun, Mar 08, 2015 at 01:41:43PM -0700, Vinson Lee wrote:
> Signed-off-by: Vinson Lee <vlee at freedesktop.org>
> ---
>  tests/deqp_gles3.py | 19 +++++++++++--------
>  1 file changed, 11 insertions(+), 8 deletions(-)
> 
> diff --git a/tests/deqp_gles3.py b/tests/deqp_gles3.py
> index 9b048f5..66f6ae3 100644
> --- a/tests/deqp_gles3.py
> +++ b/tests/deqp_gles3.py
> @@ -81,7 +81,8 @@ DEQP_GLES3_EXE = get_option('PIGLIT_DEQP_GLES3_EXE', ('deqp-gles3', 'exe'))
>  
>  # Path to the xml file which contained the case list of the subset of dEQP
>  # and marked as must pass in CTS.
> -DEQP_MUSTPASS = get_option('PIGLIT_DEQP_MUSTPASS', ('deqp-gles3', 'mustpasslist'))
> +DEQP_MUSTPASS = get_option('PIGLIT_DEQP_MUSTPASS', ('deqp-gles3',
> +                                                    'mustpasslist'))

I would break this a little differently, I think this will make the
readability better:

DEQP_MUSTPASS = get_option('PIGLIT_DEQP_MUSTPASS',
                           ('deqp-gles3', 'mustpasslist'))

>  
>  DEQP_GLES3_EXTRA_ARGS = get_option('PIGLIT_DEQP_GLES3_EXTRA_ARGS',
>                                     ('deqp-gles3', 'extra_args'))
> @@ -121,17 +122,18 @@ def iter_deqp_test_cases():
>              elif line.startswith('TEST:'):
>                  yield line[len('TEST:'):].strip()
>              else:
> -                raise Exception('{0}:{1}: ill-formed line'.format(caselist_path, i))
> +                raise Exception(
> +                    '{0}:{1}: ill-formed line'.format(caselist_path, i))
>  
>  
>  class DEQPTest(Test):
>  
> -    __RESULT_MAP = {"Pass"           : "pass",
> -                    "Fail"           : "fail",
> -                    "QualityWarning" : "warn",
> -                    "InternalError"  : "fail",
> -                    "Crash"          : "crash",
> -                    "NotSupported"   : "skip"}
> +    __RESULT_MAP = {"Pass": "pass",
> +                    "Fail": "fail",
> +                    "QualityWarning": "warn",
> +                    "InternalError": "fail",
> +                    "Crash": "crash",
> +                    "NotSupported": "skip"}

You may take flack on this hunk. I think this is fine, but I know a lot
of our developers prefer the aligned columns.

>  
>      def __init__(self, case_name):
>          command = [DEQP_GLES3_EXE, '--deqp-case=' + case_name]
> @@ -158,6 +160,7 @@ class DEQPTest(Test):
>          # We failed to parse the test output. Fallback to 'fail'.
>          self.result['result'] = 'fail'
>  
> +
>  def add_tests():
>      if DEQP_GLES3_EXE is None:
>          return
> -- 
> 2.3.1
> 
> _______________________________________________
> Piglit mailing list
> Piglit at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/piglit
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20150309/da401c1b/attachment.sig>