[Piglit] [PATCH 0/7] Replace the '/' in groups with '@'

Dylan Baker baker.dylan.c at gmail.com
Fri Mar 13 14:37:06 PDT 2015


On Fri, Mar 13, 2015 at 04:04:18PM +0000, Emil Velikov wrote:
> On 12 March 2015 at 22:42, Dylan Baker <baker.dylan.c at gmail.com> wrote:
> > This series replaces the '/' separator in groups with '@', in the
> > process it works to make another such change easier by using a constant
> > for the separator.
> >
> > This stems from problems with os.path.join being intertwined with
> > grouptools, which happens to work currently on posix systems, but breaks
> > utterly on windows.
> >
> > This series also makes a number of cleanups as this new constant
> > enables.
> >
> /me does his happy dance :-)
> 
> Thanks Dylan !
> 
> Just a couple of notes, although feel free to ignore them.
>  - Seems like there is a typo in the constant name SEPARATOR vs SEPERATOR

Oops, fixed locally

>  - Can you please add an extra replace \\ @ in the

Sure, done.

> _update_four_to_five function.
> It might not strictly be required for newer result files, but it will
> help with my ancient ones from last summer.
> 
> Cheers,
> Emil
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20150313/f0f442b0/attachment.sig>


More information about the Piglit mailing list