[Piglit] [PATCH 1/3] framework: Handle supports_gl_compat_version >= 32 with Waffle.

Brian Paul brianp at vmware.com
Mon Mar 16 10:47:26 PDT 2015


On 03/14/2015 01:45 AM, Jose Fonseca wrote:
> Per waffle_config man-page, WAFFLE_CONTEXT_CORE_PROFILE is the default
> for 3.2 contexts and above, so we must explicitly request
> WAFFLE_CONTEXT_COMPATIBILITY_PROFILE.
>
> Untested.  But should make no differnce, as all tests that have
> supports_gl_compat_version >= 32 also have supports_gl_core_version >=
> 32, which gets tried first.
> ---
>   tests/util/piglit-framework-gl/piglit_wfl_framework.c | 5 +++++
>   1 file changed, 5 insertions(+)
>
> diff --git a/tests/util/piglit-framework-gl/piglit_wfl_framework.c b/tests/util/piglit-framework-gl/piglit_wfl_framework.c
> index 5d0f569..cf7d2da 100644
> --- a/tests/util/piglit-framework-gl/piglit_wfl_framework.c
> +++ b/tests/util/piglit-framework-gl/piglit_wfl_framework.c
> @@ -296,6 +296,11 @@ make_config_attrib_list(const struct piglit_gl_test_config *test_config,
>   			head_attrib_list[i++] = WAFFLE_CONTEXT_API;
>   			head_attrib_list[i++] = WAFFLE_CONTEXT_OPENGL;
>
> +			if (test_config->supports_gl_compat_version >= 32) {
> +				head_attrib_list[i++] = WAFFLE_CONTEXT_PROFILE;
> +				head_attrib_list[i++] = WAFFLE_CONTEXT_COMPATIBILITY_PROFILE;
> +			}
> +
>   			head_attrib_list[i++] = WAFFLE_CONTEXT_MAJOR_VERSION;
>   			head_attrib_list[i++] = test_config->supports_gl_compat_version / 10;
>
>

Series LGTM.

Reviewed-by: Brian Paul <brianp at vmware.com>

I tested 2&3.



More information about the Piglit mailing list