[Piglit] [PATCH 7/7] grouptools.py: assert if \\ or / is in a group

Emil Velikov emil.l.velikov at gmail.com
Sat Mar 21 09:04:50 PDT 2015

On 16 March 2015 at 23:13, Dylan Baker <baker.dylan.c at gmail.com> wrote:
> So, I did a full run before I pushed this, and discovered an interesting
> issue.
> Some test have '/' in their names. This makes a lot of interesting
> problems. For one, the update pass I've written is wrong, since it
> naively replaces all '/' and '\\' with '@', which means that tests could
> end up with different names before and after.
> It also means that the asserts here are not safe to use.
> I guess I'll send out a v2 later today when I decide what the right way
> to handle this is.
Hi Dylan,

I've seen that you've went ahead and pushed version of this patch
which removes the assert.
Won't this cause problems as one tries to split the testname and
create the corresponding directories and/or files ?

>From a quick look it seems that tests/deqp_gles3.py does an
interesting substitution.

    for deqp_testname in iter_deqp_test_cases():
        # dEQP uses '.' as the testgroup separator.
        piglit_testname = deqp_testname.replace('.', '/')

Other than that I cannot see which other tests might have '/' in their
name, that is not used as path separator. Must admit that I've only
looked at test/*.py so maybe I wasn't looking at the right place.


More information about the Piglit mailing list