[Piglit] [PATCH] glsl-1.50: don't do link check in gs-also-uses-smooth-flat-noperspective.geom

Anuj Phogat anuj.phogat at gmail.com
Fri Mar 27 07:59:17 PDT 2015


On Fri, Mar 27, 2015 at 3:22 AM, Samuel Iglesias Gonsalvez
<siglesias at igalia.com> wrote:
> From GLSL 1.50 spec, section 4.3.4 "Inputs":
>
>   "Only the input variables that are actually read need to be written by the
>    previous stage"
>    [...]
>   "Geometry shader input variables get the per-vertex values written
>    out by vertex shader output variables of the same names."
>
> As there is not vertex shader that defines the respective output
> variables, this test should fail when linking. However, as it is checking
> that smooth and flat interpolation qualifiers are allowed in geometry
> shaders, this patch disables link checking.
>
> Signed-off-by: Samuel Iglesias Gonsalvez <siglesias at igalia.com>
> ---
>  .../spec/glsl-1.50/compiler/gs-also-uses-smooth-flat-noperspective.geom | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/spec/glsl-1.50/compiler/gs-also-uses-smooth-flat-noperspective.geom b/tests/spec/glsl-1.50/compiler/gs-also-uses-smooth-flat-noperspective.geom
> index f1ab41e..9eb0d7a 100644
> --- a/tests/spec/glsl-1.50/compiler/gs-also-uses-smooth-flat-noperspective.geom
> +++ b/tests/spec/glsl-1.50/compiler/gs-also-uses-smooth-flat-noperspective.geom
> @@ -1,7 +1,7 @@
>  // [config]
>  // expect_result: pass
>  // glsl_version: 1.50
> -// check_link: true
> +// check_link: false
>  // [end config]
>
>  #version 150
> --
> 2.1.0
>
> _______________________________________________
> Piglit mailing list
> Piglit at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/piglit

Reviewed-by: Anuj Phogat <anuj.phogat at gmail.com>


More information about the Piglit mailing list