[Piglit] [PATCH] request RGB visual, fixes gbm rendering

Ilia Mirkin imirkin at alum.mit.edu
Tue May 12 08:32:40 PDT 2015


ping? should be pretty innocuous (i'd think!)

On Sat, May 9, 2015 at 3:08 AM, Ilia Mirkin <imirkin at alum.mit.edu> wrote:
> GBM presumably defaults to RGB565 otherwise. Not all of these are
> required, as some would still work with less precision, but this makes
> the tests consistent. At least fp-formats and user-clip were failing
> previously.
>
> Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu>
> ---
>  tests/general/dlist-color-material.c  | 2 +-
>  tests/general/user-clip.c             | 2 +-
>  tests/shaders/fp-abs-01.c             | 2 +-
>  tests/shaders/fp-abs-02.c             | 2 +-
>  tests/shaders/fp-condition_codes-01.c | 2 +-
>  tests/shaders/fp-formats.c            | 2 +-
>  tests/shaders/fp-rfl.c                | 2 +-
>  tests/shaders/fp-set-01.c             | 2 +-
>  tests/shaders/fp-set-02.c             | 2 +-
>  tests/shaders/fp-unpack-01.c          | 2 +-
>  tests/shaders/vp-address-01.c         | 2 +-
>  tests/shaders/vp-address-02.c         | 2 +-
>  tests/shaders/vp-address-03.c         | 2 +-
>  tests/shaders/vp-address-04.c         | 2 +-
>  tests/shaders/vp-address-05.c         | 2 +-
>  tests/shaders/vp-address-06.c         | 2 +-
>  tests/shaders/vp-clipdistance-01.c    | 2 +-
>  tests/shaders/vp-clipdistance-02.c    | 2 +-
>  tests/shaders/vp-clipdistance-03.c    | 2 +-
>  tests/shaders/vp-clipdistance-04.c    | 2 +-
>  20 files changed, 20 insertions(+), 20 deletions(-)
>
> diff --git a/tests/general/dlist-color-material.c b/tests/general/dlist-color-material.c
> index 3c32375..ec4c30c 100644
> --- a/tests/general/dlist-color-material.c
> +++ b/tests/general/dlist-color-material.c
> @@ -39,7 +39,7 @@ PIGLIT_GL_TEST_CONFIG_BEGIN
>
>         config.supports_gl_compat_version = 10;
>
> -       config.window_visual = PIGLIT_GL_VISUAL_DOUBLE;
> +       config.window_visual = PIGLIT_GL_VISUAL_RGB | PIGLIT_GL_VISUAL_DOUBLE;
>
>  PIGLIT_GL_TEST_CONFIG_END
>
> diff --git a/tests/general/user-clip.c b/tests/general/user-clip.c
> index df055ff..7b7b232 100644
> --- a/tests/general/user-clip.c
> +++ b/tests/general/user-clip.c
> @@ -35,7 +35,7 @@ PIGLIT_GL_TEST_CONFIG_BEGIN
>
>         config.supports_gl_compat_version = 10;
>
> -       config.window_visual = PIGLIT_GL_VISUAL_DOUBLE;
> +       config.window_visual = PIGLIT_GL_VISUAL_RGB | PIGLIT_GL_VISUAL_DOUBLE;
>
>  PIGLIT_GL_TEST_CONFIG_END
>
> diff --git a/tests/shaders/fp-abs-01.c b/tests/shaders/fp-abs-01.c
> index 47d4e0f..a3ebf11 100644
> --- a/tests/shaders/fp-abs-01.c
> +++ b/tests/shaders/fp-abs-01.c
> @@ -42,7 +42,7 @@ PIGLIT_GL_TEST_CONFIG_BEGIN
>         config.supports_gl_compat_version = 10;
>         config.window_width = MAX2(TEST_WIDTH, config.window_width);
>         config.window_height = MAX2(TEST_HEIGHT, config.window_height);
> -       config.window_visual = PIGLIT_GL_VISUAL_DOUBLE;
> +       config.window_visual = PIGLIT_GL_VISUAL_RGB | PIGLIT_GL_VISUAL_DOUBLE;
>
>  PIGLIT_GL_TEST_CONFIG_END
>
> diff --git a/tests/shaders/fp-abs-02.c b/tests/shaders/fp-abs-02.c
> index 7a546a2..9b3d915 100644
> --- a/tests/shaders/fp-abs-02.c
> +++ b/tests/shaders/fp-abs-02.c
> @@ -40,7 +40,7 @@ PIGLIT_GL_TEST_CONFIG_BEGIN
>
>         config.window_width = (((BOX_SIZE+1)*TEST_COLS)+1);
>         config.window_height = (((BOX_SIZE+1)*TEST_ROWS)+1);
> -       config.window_visual = PIGLIT_GL_VISUAL_DOUBLE;
> +       config.window_visual = PIGLIT_GL_VISUAL_RGB | PIGLIT_GL_VISUAL_DOUBLE;
>
>  PIGLIT_GL_TEST_CONFIG_END
>
> diff --git a/tests/shaders/fp-condition_codes-01.c b/tests/shaders/fp-condition_codes-01.c
> index 49e3b3d..a2b249b 100644
> --- a/tests/shaders/fp-condition_codes-01.c
> +++ b/tests/shaders/fp-condition_codes-01.c
> @@ -47,7 +47,7 @@ PIGLIT_GL_TEST_CONFIG_BEGIN
>
>         config.window_width = (((BOX_SIZE+1)*TEST_ROWS)+1);
>         config.window_height = (((BOX_SIZE+1)*TEST_COLS)+1);
> -       config.window_visual = PIGLIT_GL_VISUAL_DOUBLE;
> +       config.window_visual = PIGLIT_GL_VISUAL_RGB | PIGLIT_GL_VISUAL_DOUBLE;
>
>  PIGLIT_GL_TEST_CONFIG_END
>
> diff --git a/tests/shaders/fp-formats.c b/tests/shaders/fp-formats.c
> index fe418fe..1edcb3a 100644
> --- a/tests/shaders/fp-formats.c
> +++ b/tests/shaders/fp-formats.c
> @@ -34,7 +34,7 @@ PIGLIT_GL_TEST_CONFIG_BEGIN
>
>         config.supports_gl_compat_version = 10;
>
> -       config.window_visual = PIGLIT_GL_VISUAL_DOUBLE;
> +       config.window_visual = PIGLIT_GL_VISUAL_RGB | PIGLIT_GL_VISUAL_DOUBLE;
>
>  PIGLIT_GL_TEST_CONFIG_END
>
> diff --git a/tests/shaders/fp-rfl.c b/tests/shaders/fp-rfl.c
> index 68cd9b9..7dfe216 100644
> --- a/tests/shaders/fp-rfl.c
> +++ b/tests/shaders/fp-rfl.c
> @@ -48,7 +48,7 @@ PIGLIT_GL_TEST_CONFIG_BEGIN
>
>         config.window_width = (((BOX_SIZE+1)*TEST_COLS)+1);
>         config.window_height = (((BOX_SIZE+1)*TEST_ROWS)+1);
> -       config.window_visual = PIGLIT_GL_VISUAL_DOUBLE;
> +       config.window_visual = PIGLIT_GL_VISUAL_RGB | PIGLIT_GL_VISUAL_DOUBLE;
>
>  PIGLIT_GL_TEST_CONFIG_END
>
> diff --git a/tests/shaders/fp-set-01.c b/tests/shaders/fp-set-01.c
> index b3879b0..84a4ce8 100644
> --- a/tests/shaders/fp-set-01.c
> +++ b/tests/shaders/fp-set-01.c
> @@ -46,7 +46,7 @@ PIGLIT_GL_TEST_CONFIG_BEGIN
>
>         config.window_width = (((BOX_SIZE+1)*TEST_COLS)+1);
>         config.window_height = (((BOX_SIZE+1)*TEST_ROWS)+1);
> -       config.window_visual = PIGLIT_GL_VISUAL_DOUBLE;
> +       config.window_visual = PIGLIT_GL_VISUAL_RGB | PIGLIT_GL_VISUAL_DOUBLE;
>
>  PIGLIT_GL_TEST_CONFIG_END
>
> diff --git a/tests/shaders/fp-set-02.c b/tests/shaders/fp-set-02.c
> index 9995ec9..e88cc61 100644
> --- a/tests/shaders/fp-set-02.c
> +++ b/tests/shaders/fp-set-02.c
> @@ -75,7 +75,7 @@ PIGLIT_GL_TEST_CONFIG_BEGIN
>
>         config.window_width = (((BOX_SIZE+1)*TEST_COLS)+1);
>         config.window_height = (((BOX_SIZE+1)*TEST_ROWS)+1);
> -       config.window_visual = PIGLIT_GL_VISUAL_DOUBLE;
> +       config.window_visual = PIGLIT_GL_VISUAL_RGB | PIGLIT_GL_VISUAL_DOUBLE;
>
>  PIGLIT_GL_TEST_CONFIG_END
>
> diff --git a/tests/shaders/fp-unpack-01.c b/tests/shaders/fp-unpack-01.c
> index eae656e..bf06142 100644
> --- a/tests/shaders/fp-unpack-01.c
> +++ b/tests/shaders/fp-unpack-01.c
> @@ -47,7 +47,7 @@ PIGLIT_GL_TEST_CONFIG_BEGIN
>
>         config.window_width = (((BOX_SIZE+1)*TEST_COLS)+1);
>         config.window_height = (((BOX_SIZE+1)*TEST_ROWS)+1);
> -       config.window_visual = PIGLIT_GL_VISUAL_DOUBLE;
> +       config.window_visual = PIGLIT_GL_VISUAL_RGB | PIGLIT_GL_VISUAL_DOUBLE;
>
>  PIGLIT_GL_TEST_CONFIG_END
>
> diff --git a/tests/shaders/vp-address-01.c b/tests/shaders/vp-address-01.c
> index 23b4493..09eeed3 100644
> --- a/tests/shaders/vp-address-01.c
> +++ b/tests/shaders/vp-address-01.c
> @@ -48,7 +48,7 @@ PIGLIT_GL_TEST_CONFIG_BEGIN
>
>         config.window_width = (((BOX_SIZE+1)*TEST_COLS)+1);
>         config.window_height = (((BOX_SIZE+1)*TEST_ROWS)+1);
> -       config.window_visual = PIGLIT_GL_VISUAL_DOUBLE;
> +       config.window_visual = PIGLIT_GL_VISUAL_RGB | PIGLIT_GL_VISUAL_DOUBLE;
>
>  PIGLIT_GL_TEST_CONFIG_END
>
> diff --git a/tests/shaders/vp-address-02.c b/tests/shaders/vp-address-02.c
> index 0b838dd..5164ba7 100644
> --- a/tests/shaders/vp-address-02.c
> +++ b/tests/shaders/vp-address-02.c
> @@ -58,7 +58,7 @@ PIGLIT_GL_TEST_CONFIG_BEGIN
>
>         config.window_width = (((BOX_SIZE+1)*TEST_COLS)+1);
>         config.window_height = (((BOX_SIZE+1)*TEST_ROWS)+1);
> -       config.window_visual = PIGLIT_GL_VISUAL_DOUBLE;
> +       config.window_visual = PIGLIT_GL_VISUAL_RGB | PIGLIT_GL_VISUAL_DOUBLE;
>
>  PIGLIT_GL_TEST_CONFIG_END
>
> diff --git a/tests/shaders/vp-address-03.c b/tests/shaders/vp-address-03.c
> index 7674809..58caeef 100644
> --- a/tests/shaders/vp-address-03.c
> +++ b/tests/shaders/vp-address-03.c
> @@ -40,7 +40,7 @@ PIGLIT_GL_TEST_CONFIG_BEGIN
>
>         config.window_width = (((BOX_SIZE+1)*TEST_COLS)+1);
>         config.window_height = (((BOX_SIZE+1)*TEST_ROWS)+1);
> -       config.window_visual = PIGLIT_GL_VISUAL_DOUBLE;
> +       config.window_visual = PIGLIT_GL_VISUAL_RGB | PIGLIT_GL_VISUAL_DOUBLE;
>
>  PIGLIT_GL_TEST_CONFIG_END
>
> diff --git a/tests/shaders/vp-address-04.c b/tests/shaders/vp-address-04.c
> index 981d559..14f1e6f 100644
> --- a/tests/shaders/vp-address-04.c
> +++ b/tests/shaders/vp-address-04.c
> @@ -77,7 +77,7 @@ PIGLIT_GL_TEST_CONFIG_BEGIN
>
>         config.window_width = (((BOX_SIZE+1)*TEST_COLS)+1);
>         config.window_height = (((BOX_SIZE+1)*TEST_ROWS)+1);
> -       config.window_visual = PIGLIT_GL_VISUAL_DOUBLE;
> +       config.window_visual = PIGLIT_GL_VISUAL_RGB | PIGLIT_GL_VISUAL_DOUBLE;
>
>  PIGLIT_GL_TEST_CONFIG_END
>
> diff --git a/tests/shaders/vp-address-05.c b/tests/shaders/vp-address-05.c
> index 1f06741..e8dfff6 100644
> --- a/tests/shaders/vp-address-05.c
> +++ b/tests/shaders/vp-address-05.c
> @@ -40,7 +40,7 @@ PIGLIT_GL_TEST_CONFIG_BEGIN
>
>         config.window_width = (((BOX_SIZE+1)*TEST_COLS)+1);
>         config.window_height = (((BOX_SIZE+1)*TEST_ROWS)+1);
> -       config.window_visual = PIGLIT_GL_VISUAL_DOUBLE;
> +       config.window_visual = PIGLIT_GL_VISUAL_RGB | PIGLIT_GL_VISUAL_DOUBLE;
>
>  PIGLIT_GL_TEST_CONFIG_END
>
> diff --git a/tests/shaders/vp-address-06.c b/tests/shaders/vp-address-06.c
> index ba0a347..23c5ea9 100644
> --- a/tests/shaders/vp-address-06.c
> +++ b/tests/shaders/vp-address-06.c
> @@ -40,7 +40,7 @@ PIGLIT_GL_TEST_CONFIG_BEGIN
>
>         config.window_width = (((BOX_SIZE+1)*TEST_COLS)+1);
>         config.window_height = (((BOX_SIZE+1)*TEST_ROWS)+1);
> -       config.window_visual = PIGLIT_GL_VISUAL_DOUBLE;
> +       config.window_visual = PIGLIT_GL_VISUAL_RGB | PIGLIT_GL_VISUAL_DOUBLE;
>
>  PIGLIT_GL_TEST_CONFIG_END
>
> diff --git a/tests/shaders/vp-clipdistance-01.c b/tests/shaders/vp-clipdistance-01.c
> index 227694f..c103c39 100644
> --- a/tests/shaders/vp-clipdistance-01.c
> +++ b/tests/shaders/vp-clipdistance-01.c
> @@ -40,7 +40,7 @@ PIGLIT_GL_TEST_CONFIG_BEGIN
>
>         config.window_width = (((BOX_SIZE+1)*TEST_COLS)+1);
>         config.window_height = (((BOX_SIZE+1)*TEST_ROWS)+1);
> -       config.window_visual = PIGLIT_GL_VISUAL_DOUBLE;
> +       config.window_visual = PIGLIT_GL_VISUAL_RGB | PIGLIT_GL_VISUAL_DOUBLE;
>
>  PIGLIT_GL_TEST_CONFIG_END
>
> diff --git a/tests/shaders/vp-clipdistance-02.c b/tests/shaders/vp-clipdistance-02.c
> index 5da7143..aadcd7b 100644
> --- a/tests/shaders/vp-clipdistance-02.c
> +++ b/tests/shaders/vp-clipdistance-02.c
> @@ -44,7 +44,7 @@ PIGLIT_GL_TEST_CONFIG_BEGIN
>
>         config.window_width = (((BOX_SIZE+1)*TEST_COLS)+1);
>         config.window_height = (((BOX_SIZE+1)*TEST_ROWS)+1);
> -       config.window_visual = PIGLIT_GL_VISUAL_DOUBLE;
> +       config.window_visual = PIGLIT_GL_VISUAL_RGB | PIGLIT_GL_VISUAL_DOUBLE;
>
>  PIGLIT_GL_TEST_CONFIG_END
>
> diff --git a/tests/shaders/vp-clipdistance-03.c b/tests/shaders/vp-clipdistance-03.c
> index 07d97e8..26c3275 100644
> --- a/tests/shaders/vp-clipdistance-03.c
> +++ b/tests/shaders/vp-clipdistance-03.c
> @@ -40,7 +40,7 @@ PIGLIT_GL_TEST_CONFIG_BEGIN
>
>         config.window_width = (((BOX_SIZE+1)*TEST_COLS)+1);
>         config.window_height = (((BOX_SIZE+1)*TEST_ROWS)+1);
> -       config.window_visual = PIGLIT_GL_VISUAL_DOUBLE;
> +       config.window_visual = PIGLIT_GL_VISUAL_RGB | PIGLIT_GL_VISUAL_DOUBLE;
>
>  PIGLIT_GL_TEST_CONFIG_END
>
> diff --git a/tests/shaders/vp-clipdistance-04.c b/tests/shaders/vp-clipdistance-04.c
> index 6d1dc55..4172d00 100644
> --- a/tests/shaders/vp-clipdistance-04.c
> +++ b/tests/shaders/vp-clipdistance-04.c
> @@ -44,7 +44,7 @@ PIGLIT_GL_TEST_CONFIG_BEGIN
>
>         config.window_width = (((BOX_SIZE+1)*TEST_COLS)+1);
>         config.window_height = (((BOX_SIZE+1)*TEST_ROWS)+1);
> -       config.window_visual = PIGLIT_GL_VISUAL_DOUBLE;
> +       config.window_visual = PIGLIT_GL_VISUAL_RGB | PIGLIT_GL_VISUAL_DOUBLE;
>
>  PIGLIT_GL_TEST_CONFIG_END
>
> --
> 2.3.6
>


More information about the Piglit mailing list